aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'misc-fixes' into 'dev'Mario2024-06-172-12/+113
|\ | | | | | | | | Add module test helper expectRedirectTo + api docs See merge request hubzilla/core!2138
| * Update API docs for Module test case base class.Harald Eilertsen2024-06-161-6/+98
| |
| * tests: Add helper expectRedirectTo to module test class.Harald Eilertsen2024-06-161-0/+6
| | | | | | | | | | Just a shorthand for manually stubbing `goaway` and setting the expectations on the test case.
| * Refactor is_local_url() and add api doc.Harald Eilertsen2024-06-161-6/+9
| |
* | Merge branch 'add-tests-for-create-identity' into 'dev'Mario2024-06-177-82/+157
|\ \ | |/ |/| | | | | Add tests for create_identity + fixes See merge request hubzilla/core!2137
| * Missing include in QueueWorker.Harald Eilertsen2024-06-151-0/+2
| |
| * Use empty() to check if array entry exist in create_identity.Harald Eilertsen2024-06-141-2/+2
| |
| * Add basic test for create_identity function.Harald Eilertsen2024-06-141-0/+65
| | | | | | | | | | Not an exhaustive test for now, but does at least excercise some of the code.
| * Allow passing callable as array to hooks.Harald Eilertsen2024-06-142-10/+76
| |
| * QueueWorker: Use DbaTransaction class for db transactions.Harald Eilertsen2024-06-141-24/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | This makes sure that the system knows whether a transaction is active or not, and ensures automatic cleanup if the transaction is not closed before the methods return. It also allows us to run this code in tests. When run within a test, the transaction will be ignored, as the entire test is run within an already existing transaction. Also as each test has their own db connection, this should not have any ill effects, as there should not be any way in which different simultaneous connections can interfere with the db updates.
| * tests: Remove obsolete stubs from Permissions testsHarald Eilertsen2024-06-142-46/+0
|/ | | | These stubs are no longer needed, as the tests have a db now.
* Merge branch 'fix-rpost-module' into 'dev'Mario2024-06-137-129/+218
|\ | | | | | | | | Refactoring and fixed for Module\Rpost See merge request hubzilla/core!2136
| * Module\Rpost: Just a little bit of doc.Harald Eilertsen2024-06-131-0/+6
| |
| * Module\Rpost: Redirect to submitted post on success.Harald Eilertsen2024-06-131-10/+1
| | | | | | | | | | | | This eliminates a open redirect issue where it was possible to craft a link that when clicked would take the victim to an external site controlled by an attacker.
| * Fix warnings exposed by tests.Harald Eilertsen2024-06-134-8/+11
| | | | | | | | Mainly missing variables for templates, and channel entries.
| * Module\Rpost: Add return type and visibilty for `get`.Harald Eilertsen2024-06-131-1/+1
| |
| * tests: More tests for Module\Rpost.Harald Eilertsen2024-06-131-14/+44
| | | | | | | | Also refactor the tests a bit to avoid duplicatng code.
| * Module\Rpost: Refactor handling of attachments.Harald Eilertsen2024-06-131-68/+79
| | | | | | | | Move to private function for now.
| * Module\Rpost: Reuse value of local_chanel.Harald Eilertsen2024-06-131-2/+4
| | | | | | | | We don't need to call it twice (actually trice in the original code).
| * Module\Rpost: Refactor redirect or login logic.Harald Eilertsen2024-06-131-26/+37
| |
| * tests: Module\Rpost shows login form if not authenticated.Harald Eilertsen2024-06-131-0/+13
| |
| * tests: Add comment to Tests\Unit\Module\RpostTest.Harald Eilertsen2024-06-131-0/+4
| |
| * tests: Set query string in Module\TestCase::get method.Harald Eilertsen2024-06-131-0/+1
| |
| * tests: Configure system.baseurl for tests.Harald Eilertsen2024-06-132-7/+5
| |
| * Module\Rpost: Remove obsolete local variable $o.Harald Eilertsen2024-06-131-10/+1
| |
| * Module\Rpost: Remove unused local variables.Harald Eilertsen2024-06-131-4/+1
| |
| * Module\Rpost: Add basic test and fix session access.Harald Eilertsen2024-06-132-1/+32
|/ | | | | | | | | | | | | Just a basic test to ensure that the module `get()` method behaves somewhat reasonable when no query params are given. Had to make a small change to the Rpost module itself. Since the `$_SESSION` superglobal may not always be set (and is not in the test), use `isset` instead of `array_key_exists` to check if we have saved query params in the session. In general, isset is safer than array_key_exists if there's a chance that the array itself may not exist.
* docu and remove superfluous break statement after return statementMario2024-06-131-3/+1
|
* Merge branch 'add-config-for-phpcs' into 'dev'Mario2024-06-131-0/+78
|\ | | | | | | | | Add config file and rules for PHP Code Sniffer. See merge request hubzilla/core!2135
| * Add config file and rules for PHP Code Sniffer.Harald Eilertsen2024-06-121-0/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The rules are based on the "Generic" ruleset included by PHP Code Sniffer, with a significant portion of the rules disabled. This is a tradeoff between getting some useful feedback, and not being overloaded by noise. I've tried to encode a coe style that resembles the existing code as much as possible, but have included some sniffs that requires code changes to satisfy the style. This is meant as a starting point, and we can disable or enable more sniffs as we see fit. PHPCS also has ready rule sets for other common coding standards we may want to gravitate towards, e.g. PSR-12. Others are available from the community. The best way to run PHPCS is to integrate it with your editor, so that it will display diacnostics inline when saving or modifying the code. It can also be run from the command line like this: ./vendor/bin/phpcs -n [<path-to-file-to-check>] If no file is specified it will try to check the entire project. The `-n` means don't bother with warnings (I recommend that to begin with. Enable the warnings when the errors are taken care of.)
* | Merge branch 'fix-test-warnings' into 'dev'Mario2024-06-136-14/+21
|\ \ | | | | | | | | | | | | Fix test warnings See merge request hubzilla/core!2134
| * | Module\Setup: Don't access static variable as non static.Harald Eilertsen2024-06-121-3/+3
| | |
| * | Module\Help: Only variables can be passed by reference.Harald Eilertsen2024-06-121-1/+2
| | | | | | | | | | | | | | | | | | Introduce an intermediate variable when extracting the file type from the file name. Otherwise we would try to pass a returned value as a reference.
| * | Module\Rbmark: Pass all fields to input field templates.Harald Eilertsen2024-06-121-3/+3
| | |
| * | boot/login: Pass all expected args to sub templates.Harald Eilertsen2024-06-121-3/+3
| | |
| * | Module\Rbmark: Specify all fields in the template.Harald Eilertsen2024-06-121-0/+1
| | | | | | | | | | | | | | | The `field_select` sub template wants five elements in the `field` array.
| * | includes/menu: Fix timestamp handling in menu_create.Harald Eilertsen2024-06-121-3/+4
| | | | | | | | | | | | | | | Referencing undefined array keys are not allowed anymore, so we need to check whether they exist first.
| * | Module\Setup: Pass all required params for the template.Harald Eilertsen2024-06-122-1/+5
| |/ | | | | | | | | | | Non-existing keys in the array passed to the template causes a warning. Also make optional parts of the template actually optional by skipping them if the value is empty.
* | remove not needed namespaceMario2024-06-111-2/+2
| |
* | remove not required includes and include security.php in boot.phpMario2024-06-112-8/+2
| |
* | cleanup unused codeMario2024-06-111-11/+0
| |
* | pass the force argument to the xchan_photo daemonMario2024-06-112-4/+7
| |
* | duplicate array keyMario2024-06-101-1/+0
| |
* | too many argsMario2024-06-101-2/+2
| |
* | fix wrong variableMario2024-06-101-1/+1
| |
* | remove superfluous backslashMario2024-06-102-4/+4
| |
* | Ãfix undefined variableMario2024-06-101-1/+1
| |
* | remove duplicate array keyMario2024-06-101-1/+0
| |
* | docuMario2024-06-101-2/+2
| |
* | docuMario2024-06-101-2/+2
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-12 11:04:45 +0000