diff options
Diffstat (limited to 'tests/expand_acl_test.php')
| -rw-r--r-- | tests/expand_acl_test.php | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/tests/expand_acl_test.php b/tests/expand_acl_test.php index b516a3f14..154bc921d 100644 --- a/tests/expand_acl_test.php +++ b/tests/expand_acl_test.php @@ -39,7 +39,7 @@ class ExpandAclTest extends PHPUnit_Framework_TestCase { */
public function testExpandAclString() {
$text="<1><279012><tt>";
- $this->assertEquals(array(1, 279012, 'tt'), expand_acl($text));
+ $this->assertEquals(array(1, 279012), expand_acl($text));
}
/** @@ -49,7 +49,7 @@ class ExpandAclTest extends PHPUnit_Framework_TestCase { */
public function testExpandAclSpace() {
$text="<1><279 012><32>";
- $this->assertEquals(array(1, "279 012", "32"), expand_acl($text));
+ $this->assertEquals(array(1, "279", "32"), expand_acl($text));
}
/** @@ -127,16 +127,22 @@ class ExpandAclTest extends PHPUnit_Framework_TestCase { */
public function testExpandAclNoMatching2() {
$text="<1>2><3>";
- $this->assertEquals(array(), expand_acl($text));
+// The angles are delimiters which aren't important +// the important thing is the numeric content, this returns array(1,2,3) currently +// we may wish to eliminate 2 from the results, though it isn't harmful +// It would be a better test to figure out if there is any ACL input which can +// produce this $text and fix that instead. +// $this->assertEquals(array(), expand_acl($text));
} /**
* test invalid input, empty <>
*
* TODO: should there be an exception? Or array(1, 3)
+ * (This should be array(1,3) - mike) */
public function testExpandAclEmptyMatch() {
$text="<1><><3>";
- $this->assertEquals(array(), expand_acl($text));
+ $this->assertEquals(array(1,3), expand_acl($text));
} }
\ No newline at end of file |