Merge branch '4.6RC'4.6

3 files changed, 41 insertions, 2 deletions

diff --git a/vendor/league/html-to-markdown/src/Converter/CommentConverter.php b/vendor/league/html-to-markdown/src/Converter/CommentConverter.php
index 55038b254..959381d1b 100644
--- a/vendor/league/html-to-markdown/src/Converter/CommentConverter.php
+++ b/vendor/league/html-to-markdown/src/Converter/CommentConverter.php
@@ -2,17 +2,35 @@
 
 namespace League\HTMLToMarkdown\Converter;
 
+use League\HTMLToMarkdown\Configuration;
+use League\HTMLToMarkdown\ConfigurationAwareInterface;
 use League\HTMLToMarkdown\ElementInterface;
 
-class CommentConverter implements ConverterInterface
+class CommentConverter implements ConverterInterface, ConfigurationAwareInterface
 {
     /**
+     * @var Configuration
+     */
+    protected $config;
+
+    /**
+     * @param Configuration $config
+     */
+    public function setConfig(Configuration $config)
+    {
+        $this->config = $config;
+    }
+
+    /**
      * @param ElementInterface $element
      *
      * @return string
      */
     public function convert(ElementInterface $element)
     {
+        if ($this->shouldPreserve($element)) {
+            return '<!--' . $element->getValue() . '-->';
+        }
         return '';
     }
 
@@ -23,4 +41,22 @@ class CommentConverter implements ConverterInterface
     {
         return array('#comment');
     }
+
+    /**
+     * @param ElementInterface $element
+     *
+     * @return bool
+     */
+    private function shouldPreserve(ElementInterface $element)
+    {
+        $preserve = $this->config->getOption('preserve_comments');
+        if ($preserve === true) {
+            return true;
+        }
+        if (is_array($preserve)) {
+            $value = trim($element->getValue());
+            return in_array($value, $preserve);
+        }
+        return false;
+    }
 }
diff --git a/vendor/league/html-to-markdown/src/Converter/HeaderConverter.php b/vendor/league/html-to-markdown/src/Converter/HeaderConverter.php
index 05d4fe81e..353833263 100644
--- a/vendor/league/html-to-markdown/src/Converter/HeaderConverter.php
+++ b/vendor/league/html-to-markdown/src/Converter/HeaderConverter.php
@@ -35,7 +35,7 @@ class HeaderConverter implements ConverterInterface, ConfigurationAwareInterface
         $style = $this->config->getOption('header_style', self::STYLE_SETEXT);
 
         if (strlen($element->getValue()) === 0) {
-            return '';
+            return "\n";
         }
 
         if (($level === 1 || $level === 2) && !$element->isDescendantOf('blockquote') && $style === self::STYLE_SETEXT) {
diff --git a/vendor/league/html-to-markdown/src/Converter/LinkConverter.php b/vendor/league/html-to-markdown/src/Converter/LinkConverter.php
index c82b70e97..81c18b65f 100644
--- a/vendor/league/html-to-markdown/src/Converter/LinkConverter.php
+++ b/vendor/league/html-to-markdown/src/Converter/LinkConverter.php
@@ -24,6 +24,9 @@ class LinkConverter implements ConverterInterface
         } elseif ($href === 'mailto:' . $text && $this->isValidEmail($text)) {
             $markdown = '<' . $text . '>';
         } else {
+            if (stristr($href, ' ')) {
+                $href = '<'.$href.'>';
+            }
             $markdown = '[' . $text . '](' . $href . ')';
         }