diff options
| author | zottel <github@zottel.net> | 2014-02-19 08:30:14 +0100 |
|---|---|---|
| committer | zottel <github@zottel.net> | 2014-02-19 08:30:14 +0100 |
| commit | 79d3dae7fa80df6ea6914807bcde4d8b8c390361 (patch) | |
| tree | 96327bd990038c66f0e644c505522cb424a1bbd0 /mod/item.php | |
| parent | 2bca2199112625593eb412584e17e874e71ca913 (diff) | |
| parent | 24d119b8c4e94ed130577e4e4a8d17ea13c406ac (diff) | |
| download | volse-hubzilla-79d3dae7fa80df6ea6914807bcde4d8b8c390361.tar.gz volse-hubzilla-79d3dae7fa80df6ea6914807bcde4d8b8c390361.tar.bz2 volse-hubzilla-79d3dae7fa80df6ea6914807bcde4d8b8c390361.zip | |
Merge remote-tracking branch 'upstream/master'
Diffstat (limited to 'mod/item.php')
| -rw-r--r-- | mod/item.php | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/mod/item.php b/mod/item.php index fa7720791..dc005bb20 100644 --- a/mod/item.php +++ b/mod/item.php @@ -453,6 +453,16 @@ function item_post(&$a) { * the post and we should keep it private. If it's encrypted we have no way of knowing * so we'll set the permissions regardless and realise that the media may not be * referenced in the post. + * + * What is preventing us from being able to upload photos into comments is dealing with + * the photo and attachment permissions, since we don't always know who was in the + * distribution for the top level post. + * + * We might be able to provide this functionality with a lot of fiddling: + * - if the top level post is public (make the photo public) + * - if the top level post was written by us or a wall post that belongs to us (match the top level post) + * - if the top level post has privacy mentions, add those to the permissions. + * - otherwise disallow the photo *or* make the photo public. This is the part that gets messy. */ if(! $preview) { |