Merge branch 'pull'

2 files changed, 98 insertions, 56 deletions

diff --git a/include/bbcode.php b/include/bbcode.php
index c2d932674..3caf2a6b1 100644
--- a/include/bbcode.php
+++ b/include/bbcode.php
@@ -92,17 +92,21 @@ function bbcode($Text,$preserve_nl = false) {
 	// [img=widthxheight]image source[/img]
 	$Text = preg_replace("/\[img\=([0-9]*)x([0-9]*)\](.+?)\[\/img\]/", '<img src="$3" style="height:{$2}px; width:{$1}px;" >', $Text);
 
-	// Youtube extensions
+	if (get_pconfig(local_user(), 'oembed', 'use_for_youtube' )==1){
+		// use oembed for youtube links
+		$Text = preg_replace("/\[youtube\]/",'[embed]',$Text); 
+		$Text = preg_replace("/\[\/youtube\]/",'[/embed]',$Text); 
+	} else {
+		// Youtube extensions
         $Text = preg_replace("/\[youtube\]https?:\/\/www.youtube.com\/watch\?v\=(.+?)\[\/youtube\]/",'[youtube]$1[/youtube]',$Text); 
         $Text = preg_replace("/\[youtube\]https?:\/\/youtu.be\/(.+?)\[\/youtube\]/",'[youtube]$1[/youtube]',$Text); 
-
-	$Text = preg_replace("/\[youtube\](.+?)\[\/youtube\]/", '<br /><iframe style="width:425px;height:349px;padding:10px 0 10px 0;float:left;" src="http://www.youtube.com/embed/$1" frameborder="0" allowfullscreen></iframe>', $Text);
-
-//	$Text = preg_replace("/\[youtube\](.+?)\[\/youtube\]/", '<br /><object style="width:425px;height:350px;" type="application/x-shockwave-flash" data="http://www.youtube.com/v/$1" ><param name="movie" value="http://www.youtube.com/v/$1"></param><!--[if IE]><embed src="http://www.youtube.com/v/$1" type="application/x-shockwave-flash" style="width:425px;height:350px;" /><![endif]--></object>', $Text);
+		$Text = preg_replace("/\[youtube\](.+?)\[\/youtube\]/", '<iframe width="425" height="349" src="http://www.youtube.com/embed/$1" frameborder="0" allowfullscreen></iframe>', $Text);
+	}
+//	$Text = preg_replace("/\[youtube\](.+?)\[\/youtube\]/", '<object width="425" height="350" type="application/x-shockwave-flash" data="http://www.youtube.com/v/$1" ><param name="movie" value="http://www.youtube.com/v/$1"></param><!--[if IE]><embed src="http://www.youtube.com/v/$1" type="application/x-shockwave-flash" width="425" height="350" /><![endif]--></object>', $Text);
 
 	// oembed tag
 	$Text = oembed_bbcode2html($Text);
-
+	
 	call_hooks('bbcode',$Text);
 
 	return $Text;
diff --git a/include/oembed.php b/include/oembed.php
index 4d2b7185e..06a37d8e4 100644
--- a/include/oembed.php
+++ b/include/oembed.php
@@ -1,54 +1,92 @@
 <?php
 function oembed_replacecb($matches){
-  $embedurl=$matches[1];
-  
-  $r = q("SELECT v FROM `cache` WHERE k='%s'",
-  		dbesc($embedurl));
-  if(count($r)){
-  	$txt = $r[0]['v'];
-  } else {
-	  $ourl = "http://oohembed.com/oohembed/?url=".urlencode($embedurl);  
-	  $txt = fetch_url($ourl);
-	  //save in cache
-	  q("INSERT INTO `cache` VALUES ('%s','%s','%s')",
-	  	dbesc($embedurl),
-		dbesc($txt),
-		dbesc(datetime_convert()));
-  }
-  $j = json_decode($txt);
-  $ret="<span class='oembed'>";
-  switch ($j->type) {
-    case "video": {
-       if (isset($j->thumbnail_url)) {
-         $tw = (isset($j->thumbnail_width)) ? $j->thumbnail_width:200;
-         $th = (isset($j->thumbnail_height)) ? $j->thumbnail_height:180;
-         $ret = "<a href='".$embedurl."' onclick='this.innerHTML=unescape(\"".urlencode($j->html)."\").replace(/\+/g,\" \"); return false;' >";
-         $ret.= "<img width='$tw' height='$th' src='".$j->thumbnail_url."'>";
-         $ret.= "</a>";
-       } else {
-         $ret=$j->html;
-       }
-       $ret.="<br>";
-    }; break;
-    case "photo": {
-      $ret = "<img width='".$j->width."' height='".$j->height."' src='".$j->url."'>";
-      $ret.="<br>";
-    }; break;  
-    case "link": {
-      //$ret = "<a href='".$embedurl."'>".$j->title."</a>";
-    }; break;  
-    case "rich": {
-      // not so safe.. 
-      $ret = "<blockquote>".$j->html."</blockquote>";
-    }; break;
-  }
-  
-  $embedlink = (isset($j->title))?$j->title:$embedurl;
-  $ret .= "<a href='$embedurl' rel='oembed'>$embedlink</a>";
-  if (isset($j->author_name)) $ret.=" by ".$j->author_name;
-  if (isset($j->provider_name)) $ret.=" on ".$j->provider_name;
-  $ret.="</span>";
-  return $ret;
+	$embedurl=$matches[1];
+	$j = oembed_fetch_url($embedurl);
+	return oembed_format_object($j);
+}
+
+
+function oembed_fetch_url($embedurl){
+	$r = q("SELECT v FROM `cache` WHERE k='%s'",
+				dbesc($embedurl));
+				
+	if(count($r)){
+		$txt = $r[0]['v'];
+	} else {
+		$txt = "";
+		
+		// try oembed autodiscovery
+		$html_text = fetch_url($embedurl);
+		$dom = @DOMDocument::loadHTML($html_text);
+		if ($dom){
+			$xpath = new DOMXPath($dom);
+			$attr = "oembed";
+		
+			$xattr = oe_build_xpath("class","oembed");
+			$entries = $xpath->query("//link[@type='application/json+oembed']");
+			foreach($entries as $e){
+				$href = $e->getAttributeNode("href")->nodeValue;
+				$txt = fetch_url($href);
+			}
+		}
+		
+		if ($txt==false || $txt==""){
+			// try oohembed service
+			$ourl = "http://oohembed.com/oohembed/?url=".urlencode($embedurl);  
+			$txt = fetch_url($ourl);
+		}
+		
+		$txt=trim($txt);
+		if ($txt[0]!="{") $txt='{"type":"error"}';
+	
+		//save in cache
+		/*q("INSERT INTO `cache` VALUES ('%s','%s','%s')",
+			dbesc($embedurl),
+			dbesc($txt),
+			dbesc(datetime_convert()));*/
+	}
+	
+	$j = json_decode($txt);
+	$j->embedurl = $embedurl;
+	return $j;
+}
+	
+function oembed_format_object($j){
+	$embedurl = $j->embedurl;
+	$ret="<span class='oembed ".$j->type."'>";
+	switch ($j->type) {
+		case "video": {
+			if (isset($j->thumbnail_url)) {
+				/*$tw = (isset($j->thumbnail_width)) ? $j->thumbnail_width:200;
+				$th = (isset($j->thumbnail_height)) ? $j->thumbnail_height:180;*/
+				$tw=150; $th=120; 
+				$ret.= "<a href='".$embedurl."' onclick='this.innerHTML=unescape(\"".urlencode($j->html)."\").replace(/\+/g,\" \"); return false;' style='float:left; margin: 1em; '>";
+				$ret.= "<img width='$tw' height='$th' src='".$j->thumbnail_url."'>";
+				$ret.= "</a>";
+			} else {
+				$ret=$j->html;
+			}
+			$ret.="<br>";
+		}; break;
+		case "photo": {
+			$ret.= "<img width='".$j->width."' height='".$j->height."' src='".$j->url."'>";
+			$ret.="<br>";
+		}; break;  
+		case "link": {
+			//$ret = "<a href='".$embedurl."'>".$j->title."</a>";
+		}; break;  
+		case "rich": {
+			// not so safe.. 
+			$ret.= "<blockquote>".$j->html."</blockquote>";
+		}; break;
+	}
+
+	$embedlink = (isset($j->title))?$j->title:$embedurl;
+	$ret .= "<a href='$embedurl' rel='oembed'>$embedlink</a>";
+	if (isset($j->author_name)) $ret.=" by ".$j->author_name;
+	if (isset($j->provider_name)) $ret.=" on ".$j->provider_name;
+	$ret.="<br style='clear:left'></span>";
+	return $ret;
 }
 
 function oembed_bbcode2html($text){
@@ -98,7 +136,7 @@ function oembed_html2bbcode($text) {
 		$xattr = oe_build_xpath("rel","oembed");
 		foreach($entries as $e) {
 			$href = $xpath->evaluate("a[$xattr]/@href", $e)->item(0)->nodeValue;
-			if(!is_null($href)) $e->parentNode->replaceChild(new DOMText("[embed]".$href."[embed]"), $e);
+			if(!is_null($href)) $e->parentNode->replaceChild(new DOMText("[embed]".$href."[/embed]"), $e);
 		}
 		return oe_get_inner_html( $dom->getElementsByTagName("body")->item(0) );
 	} else {