aboutsummaryrefslogtreecommitdiffstats
path: root/include/zot.php
diff options
context:
space:
mode:
authorredmatrix <redmatrix@redmatrix.me>2015-09-30 16:27:24 -0700
committerredmatrix <redmatrix@redmatrix.me>2015-09-30 16:27:24 -0700
commit5265c190d4011a7362774f86ad82a05f4f87f2b8 (patch)
tree37f254f6557ce30ab4aea0e08da416271b3691ec /include/zot.php
parentb62e7e7d8b37647c768d075f0d90a2e7d1f38190 (diff)
downloadvolse-hubzilla-5265c190d4011a7362774f86ad82a05f4f87f2b8.tar.gz
volse-hubzilla-5265c190d4011a7362774f86ad82a05f4f87f2b8.tar.bz2
volse-hubzilla-5265c190d4011a7362774f86ad82a05f4f87f2b8.zip
document the issue with cloned delivery to self vs normal delivery to self
Diffstat (limited to 'include/zot.php')
-rw-r--r--include/zot.php15
1 files changed, 13 insertions, 2 deletions
diff --git a/include/zot.php b/include/zot.php
index 488c2772f..fe51d1a7c 100644
--- a/include/zot.php
+++ b/include/zot.php
@@ -1566,6 +1566,8 @@ function process_delivery($sender, $arr, $deliveries, $relay, $public = false, $
}
}
+logger('sender: ' . print_r($sender,true));
+
foreach($deliveries as $d) {
$local_public = $public;
@@ -1584,8 +1586,17 @@ function process_delivery($sender, $arr, $deliveries, $relay, $public = false, $
$channel = $r[0];
$DR->addto_recipient($channel['channel_name'] . ' <' . $channel['channel_address'] . '@' . get_app()->get_hostname() . '>');
-// breaks comments?
-// if($d['hash'] === $sender['hash']) {
+ /**
+ * @FIXME: Somehow we need to block normal message delivery from our clones, as the delivered
+ * message doesn't have ACL information in it as the cloned copy does. That copy
+ * will normally arrive first via sync delivery, but this isn't guaranteed.
+ * There's a chance the current delivery could take place before the cloned copy arrives
+ * hence the item could have the wrong ACL and *could* be used in subsequent deliveries or
+ * access checks. So far all attempts at identifying this situation precisely
+ * have caused issues with delivery of relayed comments.
+ */
+
+// if(($d['hash'] === $sender['hash']) && ($sender['url'] !== z_root()) && (! $relay)) {
// $DR->update('self delivery ignored');
// $result[] = $DR->get();
// continue;