more efficient processing of response activities, plus a proof of concept fix for the problem of receiving a delete notification before we actually get the item which we're supposed to delete.

1 files changed, 9 insertions, 2 deletions

diff --git a/include/items.php b/include/items.php
index 2207635b6..de69a0f81 100755
--- a/include/items.php
+++ b/include/items.php
@@ -2280,9 +2280,16 @@ function item_store($arr,$allow_exec = false) {
 	);
 
 
-	send_status_notifications($current_post,$arr);
+	// If _creating_ a deleted item, don't propagate it further or send out notifications.
+	// We need to store the item details just in case the delete came in before the original post,
+	// so that we have an item in the DB that's marked deleted and won't store a fresh post 
+	// that isn't aware that we were already told to delete it.
+
+	if(! ($arr['item_restrict'] & ITEM_DELETED)) {
+		send_status_notifications($current_post,$arr);
+		tag_deliver($arr['uid'],$current_post);
+	}
 
-	tag_deliver($arr['uid'],$current_post);
 	$ret['success'] = true;
 	$ret['item_id'] = $current_post;