diff options
author | Mario <mario@mariovavti.com> | 2019-01-09 10:16:05 +0100 |
---|---|---|
committer | Mario <mario@mariovavti.com> | 2019-01-09 10:16:05 +0100 |
commit | 24354b9dcc38b72696038c98406eaa1af47eb813 (patch) | |
tree | f6f7e5492e38937c770157a3c6132d2217160cfd /Zotlabs | |
parent | c10c59db4b5f8204bfe24c2491113b4963c96dc7 (diff) | |
parent | 563a5088be7e0c439e244ab9513404a97c3d6c44 (diff) | |
download | volse-hubzilla-24354b9dcc38b72696038c98406eaa1af47eb813.tar.gz volse-hubzilla-24354b9dcc38b72696038c98406eaa1af47eb813.tar.bz2 volse-hubzilla-24354b9dcc38b72696038c98406eaa1af47eb813.zip |
Merge branch 'patch-20190107a' into 'dev'
Tweak to deal with changes that may happen within the same second.
See merge request hubzilla/core!1462
Diffstat (limited to 'Zotlabs')
-rw-r--r-- | Zotlabs/Lib/PConfig.php | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/Zotlabs/Lib/PConfig.php b/Zotlabs/Lib/PConfig.php index 5e5954c95..69f4de2db 100644 --- a/Zotlabs/Lib/PConfig.php +++ b/Zotlabs/Lib/PConfig.php @@ -131,14 +131,19 @@ class PConfig { $dbvalue = ((is_array($value)) ? serialize($value) : $value); $dbvalue = ((is_bool($dbvalue)) ? intval($dbvalue) : $dbvalue); + $now = datetime_convert(); if (! $updated) { - $updated = datetime_convert(); + //Sometimes things happen fast... very fast. + //To make sure legitimate updates aren't rejected + //because not enough time has passed. We say our updates + //happened just a short time in the past rather than right now. + $updated = datetime_convert('UTC','UTC','-2 seconds'); } $hash = hash('sha256',$family.':'.$key); if (self::Get($uid, 'hz_delpconfig', $hash) !== false) { - if (self::Get($uid, 'hz_delpconfig', $hash) > $updated) { + if (self::Get($uid, 'hz_delpconfig', $hash) > $now) { logger('Refusing to update pconfig with outdated info (Item deleted more recently).', LOGGER_NORMAL, LOG_ERR); return self::Get($uid,$family,$key); } else { @@ -173,7 +178,7 @@ class PConfig { } else { - $new = (\App::$config[$uid][$family]['pcfgud:'.$key] < $updated); + $new = (\App::$config[$uid][$family]['pcfgud:'.$key] < $now); if ($new) { @@ -241,9 +246,9 @@ class PConfig { if(is_null($uid) || $uid === false) return false; - $updated = ($updated) ? $updated : datetime_convert(); - - $newer = (\App::$config[$uid][$family]['pcfgud:'.$key] < $updated); + $updated = ($updated) ? $updated : datetime_convert('UTC','UTC','-2 seconds'); + $now = datetime_convert(); + $newer = (\App::$config[$uid][$family]['pcfgud:'.$key] < $now); if (! $newer) { logger('Refusing to delete pconfig with outdated delete request.', LOGGER_NORMAL, LOG_ERR); |