diff options
| author | redmatrix <redmatrix@redmatrix.me> | 2015-06-18 16:35:40 -0700 |
|---|---|---|
| committer | redmatrix <redmatrix@redmatrix.me> | 2015-06-18 16:35:40 -0700 |
| commit | 1a9c059062eae14a96aac40b2fb4e1efb513dccc (patch) | |
| tree | 7b142d05b5e52baeec7c538b414cacf6fd14ff4c | |
| parent | 187a7a56c2f3308521a2f0b407b2518e80a82e70 (diff) | |
| download | volse-hubzilla-1a9c059062eae14a96aac40b2fb4e1efb513dccc.tar.gz volse-hubzilla-1a9c059062eae14a96aac40b2fb4e1efb513dccc.tar.bz2 volse-hubzilla-1a9c059062eae14a96aac40b2fb4e1efb513dccc.zip | |
issues with markdownify and escaped HTML
| -rw-r--r-- | include/bb2diaspora.php | 8 | ||||
| -rw-r--r-- | include/text.php | 8 | ||||
| -rw-r--r-- | version.inc | 2 |
3 files changed, 13 insertions, 5 deletions
diff --git a/include/bb2diaspora.php b/include/bb2diaspora.php index 8129ab5e6..65f8f3ea1 100644 --- a/include/bb2diaspora.php +++ b/include/bb2diaspora.php @@ -413,10 +413,18 @@ function bb2diaspora($Text,$preserve_nl = false, $fordiaspora = true) { // Convert it to HTML - don't try oembed $Text = bbcode($Text, $preserve_nl, false); + // Markdownify does not preserve previously escaped html entities such as <> and &. + + $Text = str_replace(array('<','>','&'),array('&_lt_;','&_gt_;','&_amp_;'),$Text); + // Now convert HTML to Markdown $md = new Markdownify(false, false, false); $Text = $md->parseString($Text); + // It also adds backslashes to our attempt at getting around the html entity preservation for some weird reason. + + $Text = str_replace(array('&\\_lt\\_;','&\\_gt\\_;','&\\_amp\\_;'),array('<','>','&'),$Text); + // If the text going into bbcode() has a plain URL in it, i.e. // with no [url] tags around it, it will come out of parseString() // looking like: <http://url.com>, which gets removed by strip_tags(). diff --git a/include/text.php b/include/text.php index 9c6fe3622..7101d76da 100644 --- a/include/text.php +++ b/include/text.php @@ -1076,9 +1076,9 @@ function list_smilies() { ); $icons = array( - '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-heart.gif" alt="<3" />', - '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-brokenheart.gif" alt="</3" />', - '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-brokenheart.gif" alt="<\\3" />', + '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-heart.gif" alt="<3" />', + '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-brokenheart.gif" alt="</3" />', + '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-brokenheart.gif" alt="<\\3" />', '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-smile.gif" alt=":-)" />', '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-wink.gif" alt=";-)" />', '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-frown.gif" alt=":-(" />', @@ -1187,7 +1187,7 @@ function preg_heart($x) { $t = ''; for($cnt = 0; $cnt < strlen($x[1]); $cnt ++) - $t .= '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-heart.gif" alt="<3" />'; + $t .= '<img class="smiley" src="' . $a->get_baseurl() . '/images/smiley-heart.gif" alt="<3" />'; $r = str_replace($x[0],$t,$x[0]); diff --git a/version.inc b/version.inc index 4e53758a0..2b47a6bda 100644 --- a/version.inc +++ b/version.inc @@ -1 +1 @@ -2015-06-14.1063 +2015-06-18.1067 |