diff options
author | redmatrix <git@macgirvin.com> | 2016-05-18 22:03:43 -0700 |
---|---|---|
committer | redmatrix <git@macgirvin.com> | 2016-05-18 22:03:43 -0700 |
commit | 3355210878c6af1d4ee1719d223e83dd9e086ddc (patch) | |
tree | a76f9a1ce943b729aa1f9ca1399def9bf643afc8 | |
parent | ada26dd2cbf99e7e8395b4e466a3f73245d004f1 (diff) | |
download | volse-hubzilla-3355210878c6af1d4ee1719d223e83dd9e086ddc.tar.gz volse-hubzilla-3355210878c6af1d4ee1719d223e83dd9e086ddc.tar.bz2 volse-hubzilla-3355210878c6af1d4ee1719d223e83dd9e086ddc.zip |
explain what we're doing and where we're going with this.
-rwxr-xr-x | include/dba/dba_driver.php | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/include/dba/dba_driver.php b/include/dba/dba_driver.php index 498bfffa7..e15e107a8 100755 --- a/include/dba/dba_driver.php +++ b/include/dba/dba_driver.php @@ -32,6 +32,8 @@ function dba_factory($server, $port,$user,$pass,$db,$dbtype,$install = false) { if(is_null($port)) $set_port = 5432; $dba = new dba_postgres($server, $set_port, $user, $pass, $db, $install); } else { + +// Highly experimental at the present time. // require_once('include/dba/dba_pdo.php'); // $dba = new dba_pdo($server, $set_port,$user,$pass,$db,$install); // } @@ -42,13 +44,12 @@ function dba_factory($server, $port,$user,$pass,$db,$dbtype,$install = false) { $dba = new dba_mysqli($server, $set_port,$user,$pass,$db,$install); } } + + // Until we have a proper PDO driver, store the DB connection parameters for + // plugins/addons which use PDO natively (such as cdav). This is wasteful as + // it opens a separate connection to the DB, but saves a lot of effort re-writing + // third-party interfaces that are working and well tested. -// else { -// if (is_null($port)) $set_port = "3306"; -// require_once('include/dba/dba_mysql.php'); -// $dba = new dba_mysql($server, $set_port,$user,$pass,$db,$install); -// } -// } if(is_object($dba) && $dba->connected) { $dns = (($dbtype == DBTYPE_POSTGRES) ? 'postgres' : 'mysql') |