some high-level stuff we may need for shareable menus. Also make the client register function do the right thing even though I refuse to make it work. If **you** want service federation with things like pumpio and openid connect, it's time for **you** to put your own skin in the game and quit treating project volunteers like excrement just because you can't get up off your lazy buttocks.

2 files changed, 84 insertions, 68 deletions

diff --git a/include/api.php b/include/api.php
index 50a46dadc..6eede68f4 100644
--- a/include/api.php
+++ b/include/api.php
@@ -437,11 +437,6 @@ require_once('include/items.php');
 
 	function api_client_register(&$a,$type) {
 
-		// This currently isn't providing the correct authentication flow.
-
-		if(! local_channel())
-			goaway(z_root() . '/login');
-
 		$ret = array();
 		$key = random_string(16);
 		$secret = random_string(16);
@@ -460,12 +455,7 @@ require_once('include/items.php');
 			dbesc($name),
 			dbesc($redirect),
 			dbesc($icon),
-			intval(api_user())
-		);
-		$r = q("INSERT INTO xperm (xp_client, xp_channel, xp_perm) VALUES ('%s', %d, '%s') ",
-			dbesc($key),
-			intval(api_user()),
-			dbesc('all')
+			intval(0)
 		);
 
 		$ret['client_id'] = $key;
diff --git a/mod/impel.php b/mod/impel.php
index e78b3311d..e58264ce8 100644
--- a/mod/impel.php
+++ b/mod/impel.php
@@ -25,6 +25,10 @@ function impel_init(&$a) {
 	$channel = $a->get_channel();
 
 	$arr = array();
+	$is_menu = false;
+
+	// a portable menu has its links rewritten with the local baseurl
+	$portable_menu = false;
 
 	switch($j['type']) {
 		case 'webpage':
@@ -42,82 +46,104 @@ function impel_init(&$a) {
 			$namespace = 'PDL';
 			$installed_type = t('layout');
 			break;
+		case 'portable-menu':
+			$portable_menu = true;
+			// fall through
+		case 'menu':
+			$is_menu = true;
+			$installed_type = t('menu');
+			break;			
 		default:
 			logger('mod_impel: unrecognised element type' . print_r($j,true));
 			break;
 	}
-	$arr['uid'] = local_channel();
-	$arr['aid'] = $channel['channel_account_id'];
-	$arr['title'] = $j['title'];
-	$arr['body'] = $j['body'];
-	$arr['term'] = $j['term'];
-	$arr['created'] = datetime_convert('UTC','UTC', $j['created']);
-	$arr['edited'] = datetime_convert('UTC','UTC',$j['edited']);
-	$arr['owner_xchan'] = get_observer_hash();
-	$arr['author_xchan'] = (($j['author_xchan']) ? $j['author_xchan'] : get_observer_hash());
-	$arr['mimetype'] = (($j['mimetype']) ? $j['mimetype'] : 'text/bbcode');
-
-	if(! $j['mid'])
-		$j['mid'] = item_message_id();
-
-	$arr['mid'] = $arr['parent_mid'] = $j['mid'];
-
-
-	if($j['pagetitle']) {
-		require_once('library/urlify/URLify.php');
-		$pagetitle = strtolower(URLify::transliterate($j['pagetitle']));
-	}
+	if($is_menu) {
+
 
 
 
-	// Verify ability to use html or php!!!
 
-    $execflag = false;
 
-	if($arr['mimetype'] === 'application/x-php') {
-		$z = q("select account_id, account_roles, channel_pageflags from account left join channel on channel_account_id = account_id where channel_id = %d limit 1",
-			intval(local_channel())
-		);
 
-		if($z && (($z[0]['account_roles'] & ACCOUNT_ROLE_ALLOWCODE) || ($z[0]['channel_pageflags'] & PAGE_ALLOWCODE))) {
-			$execflag = true;
-		}
-	}
 
-	$remote_id = 0;
-
-	$z = q("select * from item_id where sid = '%s' and service = '%s' and uid = %d limit 1",
-		dbesc($pagetitle),
-		dbesc($namespace),
-		intval(local_channel())
-	);
-	$i = q("select id, item_restrict from item where mid = '%s' and uid = %d limit 1",
-		dbesc($arr['mid']),
-		intval(local_channel())
-	);
-
-	if($z && $i) {
-		$remote_id = $z[0]['id'];
-		$arr['id'] = $i[0]['id'];
-		// don't update if it has the same timestamp as the original
-		if($arr['edited'] > $i[0]['edited'])
-			$x = item_store_update($arr,$execflag);
 	}
 	else {
-		if(($i) && ($i[0]['item_restrict'] & ITEM_DELETED)) {
-			// was partially deleted already, finish it off
-			q("delete from item where mid = '%s' and uid = %d",
-				dbesc($arr['mid']),
+		$arr['uid'] = local_channel();
+		$arr['aid'] = $channel['channel_account_id'];
+		$arr['title'] = $j['title'];
+		$arr['body'] = $j['body'];
+		$arr['term'] = $j['term'];
+		$arr['created'] = datetime_convert('UTC','UTC', $j['created']);
+		$arr['edited'] = datetime_convert('UTC','UTC',$j['edited']);
+		$arr['owner_xchan'] = get_observer_hash();
+		$arr['author_xchan'] = (($j['author_xchan']) ? $j['author_xchan'] : get_observer_hash());
+		$arr['mimetype'] = (($j['mimetype']) ? $j['mimetype'] : 'text/bbcode');
+
+		if(! $j['mid'])
+			$j['mid'] = item_message_id();
+
+		$arr['mid'] = $arr['parent_mid'] = $j['mid'];
+
+
+		if($j['pagetitle']) {
+			require_once('library/urlify/URLify.php');
+			$pagetitle = strtolower(URLify::transliterate($j['pagetitle']));
+		}
+
+
+
+		// Verify ability to use html or php!!!
+
+	    $execflag = false;
+
+		if($arr['mimetype'] === 'application/x-php') {
+			$z = q("select account_id, account_roles, channel_pageflags from account left join channel on channel_account_id = account_id where channel_id = %d limit 1",
 				intval(local_channel())
 			);
+
+			if($z && (($z[0]['account_roles'] & ACCOUNT_ROLE_ALLOWCODE) || ($z[0]['channel_pageflags'] & PAGE_ALLOWCODE))) {
+				$execflag = true;
+			}
+		}
+
+		$remote_id = 0;
+
+		$z = q("select * from item_id where sid = '%s' and service = '%s' and uid = %d limit 1",
+			dbesc($pagetitle),
+			dbesc($namespace),
+			intval(local_channel())
+		);
+		$i = q("select id, item_restrict from item where mid = '%s' and uid = %d limit 1",
+			dbesc($arr['mid']),
+			intval(local_channel())
+		);
+
+		if($z && $i) {
+			$remote_id = $z[0]['id'];
+			$arr['id'] = $i[0]['id'];
+			// don't update if it has the same timestamp as the original
+			if($arr['edited'] > $i[0]['edited'])
+				$x = item_store_update($arr,$execflag);
+		}
+		else {
+			if(($i) && ($i[0]['item_restrict'] & ITEM_DELETED)) {
+				// was partially deleted already, finish it off
+				q("delete from item where mid = '%s' and uid = %d",
+					dbesc($arr['mid']),
+					intval(local_channel())
+				);
+			}
+			$x = item_store($arr,$execflag);
+		}
+
+		if($x['success']) {
+			$item_id = $x['item_id'];
+			update_remote_id($channel,$item_id,$arr['item_restrict'],$pagetitle,$namespace,$remote_id,$arr['mid']);
 		}
-		$x = item_store($arr,$execflag);
 	}
+
 	if($x['success']) {
-		$item_id = $x['item_id'];
-		update_remote_id($channel,$item_id,$arr['item_restrict'],$pagetitle,$namespace,$remote_id,$arr['mid']);
 		$ret['success'] = true;
-
 		info( sprintf( t('%s element installed'), $installed_type)); 
 	}
 	else {