From f8f01743b8b5256dda9e199f5d8e77ddb9eea278 Mon Sep 17 00:00:00 2001 From: Harald Eilertsen Date: Thu, 15 Apr 2021 00:52:54 +0200 Subject: Fix test setup for wp-env. After much reading I finally found the magic incantations, so now we can run tests with real database access. This means we no longer need the primitive $wpdb_stub. The setup as now _requires_ wp-env, or an environment set up sufficiently similar. Running in wp-env is the easiest, so aim for that. I've added a `run-tests` script that will invoke the magic incantation without having to remember it every time. To set up for testing: 1. make sure you have composer[1] installed. 2. run `composer install` 3. make sure you have wp-env[2] installed 4. start the wordpress env: `wp-env start` 5. run the tests: `./run-tests` Let the thousand tests bloom! [1]: https://github.com/wp-phpunit/wp-phpunit [2]: https://www.npmjs.com/package/@wordpress/env --- tests/VenueTest.php | 81 ++++++++++++++++++----------------------------- tests/bootstrap.php | 33 +++++++++++++++++++ tests/stubs/wpdb_stub.php | 14 -------- 3 files changed, 63 insertions(+), 65 deletions(-) create mode 100644 tests/bootstrap.php delete mode 100644 tests/stubs/wpdb_stub.php (limited to 'tests') diff --git a/tests/VenueTest.php b/tests/VenueTest.php index bea6dc4..4278951 100644 --- a/tests/VenueTest.php +++ b/tests/VenueTest.php @@ -6,97 +6,76 @@ declare(strict_types=1); -use PHPUnit\Framework\TestCase; +require __DIR__ . '/../includes/venue.php'; -require 'tests/stubs/wpdb_stub.php'; -require 'includes/venue.php'; - -final class VenueTest extends TestCase +final class VenueTest extends WP_UnitTestCase { public function testCreatingVenueWithName(): void { + $count = count(GiglogAdmin_Venue::all_venues()); + $venue = GiglogAdmin_Venue::create("Svene Samfunns- og Bedehus"); $this->assertEquals("Svene Samfunns- og Bedehus", $venue->name()); - $this->assertEquals(1, $venue->id()); + + $this->assertEquals($count + 1, count(GiglogAdmin_Venue::all_venues())); } public function testFindOrCreateNonExistingVenue() : void { + $count = count(GiglogAdmin_Venue::all_venues()); + $venue = GiglogAdmin_Venue::find_or_create("Svene Samfunns- og Bedehus"); $this->assertEquals("Svene Samfunns- og Bedehus", $venue->name()); - $this->assertEquals(1, $venue->id()); + + $this->assertEquals($count + 1, count(GiglogAdmin_Venue::all_venues())); } public function testFindOrCreateExistingVenue() : void { global $wpdb; - $results = array( - (object) [ - 'id' => 42, - 'wpgvenue_name' => 'Slarkhaillen', - 'wpgvenue_city' => 'Ofoten', - 'wpgvenue_address' => 'Baillsvingen 4', - 'wpgvenue_webpage' => 'https://slarkhaillen.no' - ]); - - $wpdb = $this->createStub(wpdb::class); - $wpdb->method('get_results')->willReturn($results); - - $venue = GiglogAdmin_Venue::find_or_create("Slarkhaillen"); + $venue = GiglogAdmin_Venue::create("Svene Samfunns- og Bedehus"); + $other = GiglogAdmin_Venue::find_or_create("Svene Samfunns- og Bedehus"); - $this->assertEquals($results[0]->id, $venue->id()); - $this->assertEquals($results[0]->wpgvenue_name, $venue->name()); + $this->assertEquals($other->id(), $venue->id()); + $this->assertEquals($other->name(), $venue->name()); } public function testFindAllVenuesInCity() : void { global $wpdb; - $results = array(); for ($i = 0; $i < 3; $i++) { - $results[$i] = (object) [ - 'id' => 42 + $i, - 'wpgvenue_name' => "Venue #" . $i, - 'wpgvenue_city' => "Osaka" - ]; + GiglogAdmin_Venue::create("Venue in Osaka #" . $i, "Osaka"); } - $wpdb = $this->createStub(wpdb::class); - $wpdb->method('prepare')->willReturn("prepared"); - $wpdb->method('get_results')->willReturn($results); - - $venues = GiglogAdmin_Venue::venues_in_city("Osaka"); + for ($i = 0; $i < 5; $i++) { + GiglogAdmin_Venue::create("Venue in Berlin #" . $i, "Berlin"); + } - for ($i = 0; $i < 3; $i++) { - $this->assertEquals("Osaka", $venues[$i]->city()); - $this->assertEquals("Venue #" . $i, $venues[$i]->name()); - $this->assertEquals(42 + $i, $venues[$i]->id()); + for ($i = 0; $i < 2; $i++) { + GiglogAdmin_Venue::create("Venue in Svene #" . $i, "Svene"); } + + $venues_in_osaka = GiglogAdmin_Venue::venues_in_city("Osaka"); + $venues_in_berlin = GiglogAdmin_Venue::venues_in_city("Berlin"); + $venues_in_svene = GiglogAdmin_Venue::venues_in_city("Svene"); + + $this->assertEquals(3, count($venues_in_osaka)); + $this->assertEquals(5, count($venues_in_berlin)); + $this->assertEquals(2, count($venues_in_svene)); } public function testFindAllVenues() : void { global $wpdb; - $results = array(); for ($i = 0; $i < 3; $i++) { - $results[$i] = (object) [ - 'id' => 42 + $i, - 'wpgvenue_name' => "Venue #" . $i, - 'wpgvenue_city' => "City #" . $i - ]; + GiglogAdmin_Venue::create("Venue #" . $i); } - $wpdb = $this->createStub(wpdb::class); - $wpdb->method('get_results')->willReturn($results); - $venues = GiglogAdmin_Venue::all_venues(); + $this->assertEquals(3, count($venues)); - for ($i = 0; $i < 3; $i++) { - $this->assertEquals("City #" . $i, $venues[$i]->city()); - $this->assertEquals("Venue #" . $i, $venues[$i]->name()); - $this->assertEquals(42 + $i, $venues[$i]->id()); - } } } diff --git a/tests/bootstrap.php b/tests/bootstrap.php new file mode 100644 index 0000000..0878ff7 --- /dev/null +++ b/tests/bootstrap.php @@ -0,0 +1,33 @@ + -// SPDX-FileCopyrightText: 2021 Harald Eilertsen -// -// SPDX-License-Identifier: AGPL-3.0-or-later - -class wpdb { - public $insert_id = NULL; - public function insert(string $table, array $data) { $this->insert_id = 1; } - public function prepare(string $query, mixed $args) { return "prepared"; } - public function get_results(string $query) { return NULL; } -} - -$wpdb = new wpdb(); -- cgit v1.2.3