From f0eb0199ec8de0e76c7b75ddc80275cde8f12818 Mon Sep 17 00:00:00 2001 From: Harald Eilertsen Date: Mon, 6 Sep 2021 16:42:51 +0200 Subject: Throw instead of log error from Concert class. Should get rid of most of the annoying output during testing, and allow moving error handling and logging to the presentation layer. --- tests/ConcertTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'tests') diff --git a/tests/ConcertTest.php b/tests/ConcertTest.php index 13df320..02ce58e 100644 --- a/tests/ConcertTest.php +++ b/tests/ConcertTest.php @@ -80,6 +80,8 @@ final class ConcertTest extends WP_UnitTestCase public function testCreateExistingConcertShouldFail() : void { + $this->expectException(GiglogAdmin_DuplicateConcertException::class); + $venue = GiglogAdmin_Venue::find_or_create("a venue", "Somewhere"); $today = date("Y-m-d"); @@ -89,12 +91,12 @@ final class ConcertTest extends WP_UnitTestCase $today, "https://example.com/tickets/42", "https://example.com/events/93"); - - $this->assertNull($new); } public function testCreateExistingConcertVariableCase() : void { + $this->expectException(GiglogAdmin_DuplicateConcertException::class); + $venue = GiglogAdmin_Venue::find_or_create("a venue", "Somewhere"); $today = date("Y-m-d"); @@ -104,8 +106,6 @@ final class ConcertTest extends WP_UnitTestCase $today, "https://example.com/tickets/42", "https://example.com/events/93"); - - $this->assertNull($new); } public function testGetConcertByIdReturnsFullConcertObject() : void -- cgit v1.2.3