From a826c6ab358e64524c4a1c1ce180404fb937993a Mon Sep 17 00:00:00 2001
From: Harald Eilertsen <haraldei@anduin.net>
Date: Sat, 12 Feb 2022 20:46:22 +0100
Subject: Fix pagination of concert table.

There's potential vulnerabilities here still, and I'm unsure if
get_permalink() is entirely safe to use in this context. Seems to do the
right thing, but the docs for the function indicates it has some edge
cases.
---
 includes/admin/views/_concerts_table.php | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

(limited to 'includes')

diff --git a/includes/admin/views/_concerts_table.php b/includes/admin/views/_concerts_table.php
index 4a9c658..b34fef1 100644
--- a/includes/admin/views/_concerts_table.php
+++ b/includes/admin/views/_concerts_table.php
@@ -153,27 +153,28 @@ if (!class_exists("GiglogAdmin_ConcertsTable"))
             $content.='<span class="alignleft">';
 
             if($page_no > 1) {
-                $content.= "<span><a href='?page_no=1'>First Page </a> - </span>";
+                $content.= '<span><a href="'. add_query_arg( 'page_no', 1, get_permalink() ) . '">First Page</a> - </span>';
             }
 
             if($page_no <= 1) {
                 $content .="<span> </span>";
             }
             else {
-                $content.= "<span> <a href='?page_no=".$previous_page."' >Previous </a> </span>";
+                $content.= '<span> <a href="' . add_query_arg( 'page_no', $previous_page, get_permalink() ) . '">Previous</a></span>';
             }
 
             $content.='</span>';
             $content.='<span class="aligncenter"><div style="padding: 10px 20px 0px; border-top: dotted 1px #CCC;"><strong>Page '.$page_no.' of '.$total_no_of_pages.'</strong></div></span>';
             $content.='<span class="alignright">';
 
-            if($page_no >= $total_no_of_pages) {
+            if ($page_no >= $total_no_of_pages) {
                 $content .= "<span></span>";
             }
 
-            if($page_no < $total_no_of_pages) {
-                $content .= '<span><a href="?page_no='.$next_page.'">Next</a> - </span>';
-                $content .= "<span><a href='?page_no=".$total_no_of_pages."'>Last Page</a></span>";
+            if ($page_no < $total_no_of_pages) {
+                global $wp;
+                $content .= '<span><a href="' . add_query_arg( 'page_no', $next_page, get_permalink() ) . '">Next</a> - </span>';
+                $content .= '<span><a href="' . add_query_arg( 'page_no', $total_no_of_pages, get_permalink() ) .'">Last Page</a></span>';
             }
 
             $content.='</span>';
-- 
cgit v1.2.3