From 32bc0bb0e3adb0a3ce025724b51b7d413a554e27 Mon Sep 17 00:00:00 2001 From: Patrick Davey Date: Thu, 17 Oct 2013 08:55:13 +1300 Subject: Restricting tags to live posts --- app/helpers/refinery/blog/controller_helper.rb | 2 +- .../refinery/blog/controller_helper_spec.rb | 25 ++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 spec/helpers/refinery/blog/controller_helper_spec.rb diff --git a/app/helpers/refinery/blog/controller_helper.rb b/app/helpers/refinery/blog/controller_helper.rb index 87d5447..edbf934 100644 --- a/app/helpers/refinery/blog/controller_helper.rb +++ b/app/helpers/refinery/blog/controller_helper.rb @@ -19,7 +19,7 @@ module Refinery end def find_tags - @tags = Refinery::Blog::Post.tag_counts_on(:tags) + @tags = Refinery::Blog::Post.live.tag_counts_on(:tags) end def find_all_blog_categories @categories = Refinery::Blog::Category.translated diff --git a/spec/helpers/refinery/blog/controller_helper_spec.rb b/spec/helpers/refinery/blog/controller_helper_spec.rb new file mode 100644 index 0000000..89eeaad --- /dev/null +++ b/spec/helpers/refinery/blog/controller_helper_spec.rb @@ -0,0 +1,25 @@ +require 'spec_helper' +module Refinery + module Blog + describe ControllerHelper do + describe "#find_tags" do + let(:tags) { helper.find_tags } + + context "with draft posts" do + let!(:blog_post) { FactoryGirl.create(:blog_post, :draft => true) } + it "does not return tags" do + tags.should be_empty + end + end + + context "with live posts" do + let!(:blog_post) { FactoryGirl.create(:blog_post) } + + it "does not return tags" do + tags.should_not be_empty + end + end + end + end + end +end -- cgit v1.2.3 From c6f4616844fd2861c95fce383bdaefa1fbc5cf62 Mon Sep 17 00:00:00 2001 From: Patrick Davey Date: Fri, 18 Oct 2013 14:18:41 +1300 Subject: Explicitly setting tag list in tests --- spec/helpers/refinery/blog/controller_helper_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/helpers/refinery/blog/controller_helper_spec.rb b/spec/helpers/refinery/blog/controller_helper_spec.rb index 89eeaad..727e8b4 100644 --- a/spec/helpers/refinery/blog/controller_helper_spec.rb +++ b/spec/helpers/refinery/blog/controller_helper_spec.rb @@ -6,14 +6,14 @@ module Refinery let(:tags) { helper.find_tags } context "with draft posts" do - let!(:blog_post) { FactoryGirl.create(:blog_post, :draft => true) } + let!(:blog_post) { FactoryGirl.create(:blog_post, :draft => true, :tag_list => "first, second" ) } it "does not return tags" do tags.should be_empty end end context "with live posts" do - let!(:blog_post) { FactoryGirl.create(:blog_post) } + let!(:blog_post) { FactoryGirl.create(:blog_post, :tag_list => "first, second" ) } it "does not return tags" do tags.should_not be_empty -- cgit v1.2.3