From bb2d7fcbf58d621e1a607df01aab5ff232255a88 Mon Sep 17 00:00:00 2001 From: Jeremy Daer Date: Sun, 9 Jul 2017 13:22:20 -0700 Subject: Tests: Dir.mktmpdir neatly wraps up tmpdir + join --- test/service/disk_service_test.rb | 1 - test/service/mirror_service_test.rb | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'test/service') diff --git a/test/service/disk_service_test.rb b/test/service/disk_service_test.rb index 565acbf516..f7752b25ef 100644 --- a/test/service/disk_service_test.rb +++ b/test/service/disk_service_test.rb @@ -1,4 +1,3 @@ -require "tmpdir" require "service/shared_service_tests" class ActiveStorage::Service::DiskServiceTest < ActiveSupport::TestCase diff --git a/test/service/mirror_service_test.rb b/test/service/mirror_service_test.rb index 6fee3cadd2..8bda01f169 100644 --- a/test/service/mirror_service_test.rb +++ b/test/service/mirror_service_test.rb @@ -1,16 +1,15 @@ -require "tmpdir" require "service/shared_service_tests" class ActiveStorage::Service::MirrorServiceTest < ActiveSupport::TestCase mirror_config = (1..3).map do |i| [ "mirror_#{i}", service: "Disk", - root: File.join(Dir.tmpdir, "active_storage_mirror_#{i}") ] + root: Dir.mktmpdir("active_storage_tests_mirror_#{i}") ] end.to_h config = mirror_config.merge \ mirror: { service: "Mirror", primary: 'primary', mirrors: mirror_config.keys }, - primary: { service: "Disk", root: File.join(Dir.tmpdir, "active_storage") } + primary: { service: "Disk", root: Dir.mktmpdir("active_storage_tests_primary") } SERVICE = ActiveStorage::Service.configure :mirror, config -- cgit v1.2.3