From 7e229f7430122461538ea6a0a3feb34c8d9eb87a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Annie-Claude=20C=C3=B4t=C3=A9?= <hello@annie.codes>
Date: Thu, 5 Jul 2018 09:55:36 -0400
Subject: Make NotesCommand tests more performant by getting rid of unecessary
map * Get rid of map and replace it with a multiplication of "\n" to generate
document with multiple line preceding the annotation * Reduce number from
1000 to 100 since it achieves the same goal * Only keep one test for the
multiple lines document since it's unecessary to test multiple times * Update
some language in tests names to make it clearer what we are testing
---
railties/test/commands/notes_test.rb | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
(limited to 'railties')
diff --git a/railties/test/commands/notes_test.rb b/railties/test/commands/notes_test.rb
index d8647b3aca..147019e299 100644
--- a/railties/test/commands/notes_test.rb
+++ b/railties/test/commands/notes_test.rb
@@ -8,51 +8,51 @@ class Rails::Command::NotesTest < ActiveSupport::TestCase
setup :build_app
teardown :teardown_app
- test "`rails notes` displays results for default directories and default annotations" do
+ test "`rails notes` displays results for default directories and default annotations with aligned line number and annotation tag" do
app_file "app/controllers/some_controller.rb", "# OPTIMIZE: note in app directory"
app_file "config/initializers/some_initializer.rb", "# TODO: note in config directory"
app_file "db/some_seeds.rb", "# FIXME: note in db directory"
app_file "lib/some_file.rb", "# TODO: note in lib directory"
- app_file "test/some_test.rb", 1000.times.map { "" }.join("\n") << "# FIXME: note in test directory"
+ app_file "test/some_test.rb", "\n" * 100 + "# FIXME: note in test directory"
app_file "some_other_dir/blah.rb", "# TODO: note in some_other directory"
assert_equal <<~OUTPUT, run_notes_command
app/controllers/some_controller.rb:
- * [ 1] [OPTIMIZE] note in app directory
+ * [ 1] [OPTIMIZE] note in app directory
config/initializers/some_initializer.rb:
- * [ 1] [TODO] note in config directory
+ * [ 1] [TODO] note in config directory
db/some_seeds.rb:
- * [ 1] [FIXME] note in db directory
+ * [ 1] [FIXME] note in db directory
lib/some_file.rb:
- * [ 1] [TODO] note in lib directory
+ * [ 1] [TODO] note in lib directory
test/some_test.rb:
- * [1000] [FIXME] note in test directory
+ * [101] [FIXME] note in test directory
OUTPUT
end
- test "`rails notes` displays an empty array when no results were found" do
+ test "`rails notes` displays an empty string when no results were found" do
assert_equal "", run_notes_command
end
test "`rails notes --annotations` displays results for a single annotation without being prefixed by a tag" do
app_file "db/some_seeds.rb", "# FIXME: note in db directory"
- app_file "test/some_test.rb", 1000.times.map { "" }.join("\n") << "# FIXME: note in test directory"
+ app_file "test/some_test.rb", "# FIXME: note in test directory"
app_file "app/controllers/some_controller.rb", "# OPTIMIZE: note in app directory"
app_file "config/initializers/some_initializer.rb", "# TODO: note in config directory"
assert_equal <<~OUTPUT, run_notes_command(["--annotations", "FIXME"])
db/some_seeds.rb:
- * [ 1] note in db directory
+ * [1] note in db directory
test/some_test.rb:
- * [1000] note in test directory
+ * [1] note in test directory
OUTPUT
end
@@ -62,7 +62,7 @@ class Rails::Command::NotesTest < ActiveSupport::TestCase
app_file "config/initializers/some_initializer.rb", "# TODO: note in config directory"
app_file "lib/some_file.rb", "# TODO: note in lib directory"
- app_file "test/some_test.rb", 1000.times.map { "" }.join("\n") << "# FIXME: note in test directory"
+ app_file "test/some_test.rb", "# FIXME: note in test directory"
assert_equal <<~OUTPUT, run_notes_command(["--annotations", "FOOBAR", "TODO"])
app/controllers/some_controller.rb:
--
cgit v1.2.3