From 312f43324159fbcd8749cd331ed7d6500a714a83 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Valim?= <jose.valim@gmail.com>
Date: Sat, 19 Jun 2010 17:51:29 +0200
Subject: Clear DescendantsTracker on each request.

---
 railties/lib/rails/application/bootstrap.rb        |  2 +
 .../application/initializers/load_path_test.rb     |  2 +-
 railties/test/application/loading_test.rb          | 73 ++++++++++++++++++++++
 .../test/application/model_initialization_test.rb  | 33 ----------
 railties/test/application/rake_test.rb             |  2 +-
 5 files changed, 77 insertions(+), 35 deletions(-)
 create mode 100644 railties/test/application/loading_test.rb
 delete mode 100644 railties/test/application/model_initialization_test.rb

(limited to 'railties')

diff --git a/railties/lib/rails/application/bootstrap.rb b/railties/lib/rails/application/bootstrap.rb
index 0a435f0f36..44e26b5713 100644
--- a/railties/lib/rails/application/bootstrap.rb
+++ b/railties/lib/rails/application/bootstrap.rb
@@ -1,4 +1,5 @@
 require "active_support/notifications"
+require "active_support/descendants_tracker"
 
 module Rails
   class Application
@@ -55,6 +56,7 @@ module Rails
       initializer :set_clear_dependencies_hook do
         unless config.cache_classes
           ActionDispatch::Callbacks.after do
+            ActiveSupport::DescendantsTracker.clear
             ActiveSupport::Dependencies.clear
           end
         end
diff --git a/railties/test/application/initializers/load_path_test.rb b/railties/test/application/initializers/load_path_test.rb
index d31915e129..714d62311d 100644
--- a/railties/test/application/initializers/load_path_test.rb
+++ b/railties/test/application/initializers/load_path_test.rb
@@ -19,7 +19,7 @@ module ApplicationTests
       assert $:.include?("#{app_path}/app/models")
     end
 
-    test "initializing an application adds lib path on inheritance hook" do
+    test "initializing an application allows to load code on lib path inside application class definitation" do
       app_file "lib/foo.rb", <<-RUBY
         module Foo; end
       RUBY
diff --git a/railties/test/application/loading_test.rb b/railties/test/application/loading_test.rb
new file mode 100644
index 0000000000..b337d3fc6e
--- /dev/null
+++ b/railties/test/application/loading_test.rb
@@ -0,0 +1,73 @@
+require 'isolation/abstract_unit'
+
+class LoadingTest < Test::Unit::TestCase
+  include ActiveSupport::Testing::Isolation
+
+  def setup
+    build_app
+    boot_rails
+  end
+
+  def app
+    @app ||= Rails.application
+  end
+
+  def test_load_should_load_constants
+    app_file "app/models/post.rb", <<-MODEL
+      class Post < ActiveRecord::Base
+        validates_acceptance_of :title, :accept => "omg"
+      end
+    MODEL
+  
+    require "#{rails_root}/config/environment"
+    setup_ar!
+  
+    p = Post.create(:title => 'omg')
+    assert_equal 1, Post.count
+    assert_equal 'omg', p.title
+    p = Post.first
+    assert_equal 'omg', p.title
+  end
+
+  def test_descendants_are_cleaned_on_each_request_without_cache_classes
+    add_to_config <<-RUBY
+      config.cache_classes = false
+    RUBY
+
+    app_file "app/models/post.rb", <<-MODEL
+      class Post < ActiveRecord::Base
+      end
+    MODEL
+
+    app_file 'config/routes.rb', <<-RUBY
+      AppTemplate::Application.routes.draw do |map|
+        match '/load',   :to => lambda { |env| [200, {}, Post.all] }
+        match '/unload', :to => lambda { |env| [200, {}, []] }
+      end
+    RUBY
+
+    require 'rack/test'
+    extend Rack::Test::Methods
+
+    require "#{rails_root}/config/environment"
+    setup_ar!
+
+    assert_equal [], ActiveRecord::Base.descendants
+    get "/load"
+    assert_equal [Post], ActiveRecord::Base.descendants
+    get "/unload"
+    assert_equal [], ActiveRecord::Base.descendants
+  end
+
+  protected
+  
+  def setup_ar!
+    ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")
+    ActiveRecord::Migration.verbose = false
+    ActiveRecord::Schema.define(:version => 1) do
+      create_table :posts do |t|
+        t.string :title
+      end
+    end
+  end
+end
diff --git a/railties/test/application/model_initialization_test.rb b/railties/test/application/model_initialization_test.rb
deleted file mode 100644
index 6a22f8d8df..0000000000
--- a/railties/test/application/model_initialization_test.rb
+++ /dev/null
@@ -1,33 +0,0 @@
-require 'isolation/abstract_unit'
-
-class PostTest < Test::Unit::TestCase
-  include ActiveSupport::Testing::Isolation
-
-  def setup
-    build_app
-    boot_rails
-  end
-
-  def test_reload_should_reload_constants
-    app_file "app/models/post.rb", <<-MODEL
-      class Post < ActiveRecord::Base
-        validates_acceptance_of :title, :accept => "omg"
-      end
-    MODEL
-
-    require "#{rails_root}/config/environment"
-    ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")
-    ActiveRecord::Migration.verbose = false
-    ActiveRecord::Schema.define(:version => 1) do
-      create_table :posts do |t|
-        t.string :title
-      end
-    end
-
-    p = Post.create(:title => 'omg')
-    assert_equal 1, Post.count
-    assert_equal 'omg', p.title
-    p = Post.first
-    assert_equal 'omg', p.title
-  end
-end
diff --git a/railties/test/application/rake_test.rb b/railties/test/application/rake_test.rb
index 6b7a471494..40fb446b16 100644
--- a/railties/test/application/rake_test.rb
+++ b/railties/test/application/rake_test.rb
@@ -9,7 +9,7 @@ module ApplicationTests
       boot_rails
       FileUtils.rm_rf("#{app_path}/config/environments")
     end
-    
+
     def test_gems_tasks_are_loaded_first_than_application_ones
       app_file "lib/tasks/app.rake", <<-RUBY
         $task_loaded = Rake::Task.task_defined?("db:create:all")
-- 
cgit v1.2.3