From 3af8a91c384761ab8772c57ab1ee0ea1b8fe69e7 Mon Sep 17 00:00:00 2001 From: thedarkone Date: Tue, 6 Aug 2013 17:01:10 +0200 Subject: Add a missing require. This makes the rack_logger_test.rb runnable by itself (outside of the `rake test` suite). --- railties/test/rack_logger_test.rb | 1 + 1 file changed, 1 insertion(+) (limited to 'railties/test') diff --git a/railties/test/rack_logger_test.rb b/railties/test/rack_logger_test.rb index cfd2c5b50a..635a8a8865 100644 --- a/railties/test/rack_logger_test.rb +++ b/railties/test/rack_logger_test.rb @@ -1,3 +1,4 @@ +require 'abstract_unit' require 'active_support/testing/autorun' require 'active_support/test_case' require 'rails/rack/logger' -- cgit v1.2.3 From a0907bbdad0b8cbead9c8d295b9037036ec650d0 Mon Sep 17 00:00:00 2001 From: thedarkone Date: Tue, 6 Aug 2013 17:03:29 +0200 Subject: "Naked" rescue clauses only catch StandardError subclasses. Similar to #11497. --- railties/test/rack_logger_test.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'railties/test') diff --git a/railties/test/rack_logger_test.rb b/railties/test/rack_logger_test.rb index 635a8a8865..6ebd47fff9 100644 --- a/railties/test/rack_logger_test.rb +++ b/railties/test/rack_logger_test.rb @@ -57,11 +57,14 @@ module Rails end def test_notification_on_raise - logger = TestLogger.new { raise } + logger = TestLogger.new do + # using an exception class that is not a StandardError subclass on purpose + raise NotImplementedError + end assert_difference('subscriber.starts.length') do assert_difference('subscriber.finishes.length') do - assert_raises(RuntimeError) do + assert_raises(NotImplementedError) do logger.call 'REQUEST_METHOD' => 'GET' end end -- cgit v1.2.3