From 783763bde97bea3d0c200038453008a8cfff1e88 Mon Sep 17 00:00:00 2001 From: Xavier Noria Date: Sat, 6 Aug 2016 19:16:09 +0200 Subject: applies new string literal convention in railties/test The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. --- railties/test/abstract_unit.rb | 24 +- railties/test/app_loader_test.rb | 14 +- railties/test/application/asset_debugging_test.rb | 8 +- railties/test/application/assets_test.rb | 58 +-- railties/test/application/bin_setup_test.rb | 8 +- .../test/application/configuration/custom_test.rb | 6 +- railties/test/application/configuration_test.rb | 400 ++++++++++----------- railties/test/application/console_test.rb | 12 +- railties/test/application/generators_test.rb | 2 +- .../application/initializers/frameworks_test.rb | 14 +- .../test/application/initializers/hooks_test.rb | 2 +- .../test/application/initializers/i18n_test.rb | 18 +- .../application/initializers/notifications_test.rb | 8 +- .../test/application/integration_test_case_test.rb | 8 +- railties/test/application/loading_test.rb | 38 +- railties/test/application/mailer_previews_test.rb | 156 ++++---- railties/test/application/middleware/cache_test.rb | 10 +- .../test/application/middleware/cookies_test.rb | 20 +- .../test/application/middleware/exceptions_test.rb | 16 +- .../test/application/middleware/remote_ip_test.rb | 12 +- .../test/application/middleware/sendfile_test.rb | 6 +- .../test/application/middleware/session_test.rb | 134 +++---- .../test/application/middleware/static_test.rb | 22 +- railties/test/application/middleware_test.rb | 10 +- .../test/application/multiple_applications_test.rb | 10 +- .../application/per_request_digest_cache_test.rb | 26 +- railties/test/application/rack/logger_test.rb | 4 +- railties/test/application/rackup_test.rb | 2 +- railties/test/application/rake/dbs_test.rb | 64 ++-- railties/test/application/rake/dev_test.rb | 12 +- railties/test/application/rake/framework_test.rb | 10 +- railties/test/application/rake/migrations_test.rb | 32 +- railties/test/application/rake/notes_test.rb | 28 +- railties/test/application/rake/restart_test.rb | 10 +- railties/test/application/rake_test.rb | 22 +- railties/test/application/rendering_test.rb | 14 +- railties/test/application/routing_test.rb | 178 ++++----- railties/test/application/runner_test.rb | 4 +- railties/test/application/test_runner_test.rb | 248 ++++++------- railties/test/application/test_test.rb | 78 ++-- railties/test/application/url_generation_test.rb | 6 +- railties/test/backtrace_cleaner_test.rb | 4 +- railties/test/code_statistics_calculator_test.rb | 42 +-- railties/test/code_statistics_test.rb | 18 +- railties/test/commands/console_test.rb | 26 +- railties/test/commands/dbconsole_test.rb | 112 +++--- railties/test/commands/server_test.rb | 30 +- .../configuration/middleware_stack_proxy_test.rb | 10 +- railties/test/engine_test.rb | 2 +- railties/test/env_helpers.rb | 10 +- .../generators/active_record/fixjour_generator.rb | 2 +- .../usage_template/usage_template_generator.rb | 2 +- railties/test/generators/actions_test.rb | 158 ++++---- railties/test/generators/api_app_generator_test.rb | 6 +- railties/test/generators/app_generator_test.rb | 98 ++--- railties/test/generators/argv_scrubber_test.rb | 64 ++-- railties/test/generators/assets_generator_test.rb | 4 +- railties/test/generators/channel_generator_test.rb | 20 +- .../test/generators/controller_generator_test.rb | 4 +- railties/test/generators/create_migration_test.rb | 8 +- .../test/generators/generated_attribute_test.rb | 34 +- .../test/generators/generator_generator_test.rb | 4 +- railties/test/generators/generator_test.rb | 52 +-- railties/test/generators/generators_test_helper.rb | 22 +- railties/test/generators/helper_generator_test.rb | 4 +- .../generators/integration_test_generator_test.rb | 4 +- railties/test/generators/job_generator_test.rb | 4 +- railties/test/generators/mailer_generator_test.rb | 6 +- .../test/generators/migration_generator_test.rb | 8 +- railties/test/generators/model_generator_test.rb | 6 +- railties/test/generators/named_base_test.rb | 144 ++++---- .../test/generators/namespaced_generators_test.rb | 10 +- railties/test/generators/plugin_generator_test.rb | 92 ++--- railties/test/generators/plugin_test_helper.rb | 6 +- .../test/generators/plugin_test_runner_test.rb | 50 +-- .../test/generators/resource_generator_test.rb | 4 +- .../scaffold_controller_generator_test.rb | 4 +- .../test/generators/scaffold_generator_test.rb | 12 +- railties/test/generators/shared_generator_tests.rb | 20 +- railties/test/generators/task_generator_test.rb | 8 +- .../test/generators/test_runner_in_engine_test.rb | 10 +- railties/test/generators_test.rb | 18 +- railties/test/initializable_test.rb | 8 +- railties/test/isolation/abstract_unit.rb | 52 +-- railties/test/path_generation_test.rb | 22 +- railties/test/paths_test.rb | 6 +- railties/test/rack_logger_test.rb | 24 +- railties/test/rails_info_controller_test.rb | 38 +- railties/test/rails_info_test.rb | 24 +- railties/test/railties/engine_test.rb | 52 +-- railties/test/railties/generators_test.rb | 8 +- railties/test/railties/mounted_engine_test.rb | 26 +- railties/test/railties/railtie_test.rb | 16 +- railties/test/test_unit/reporter_test.rb | 16 +- railties/test/version_test.rb | 2 +- 95 files changed, 1595 insertions(+), 1595 deletions(-) (limited to 'railties/test') diff --git a/railties/test/abstract_unit.rb b/railties/test/abstract_unit.rb index 2a5a731fe2..fd1e1b9662 100644 --- a/railties/test/abstract_unit.rb +++ b/railties/test/abstract_unit.rb @@ -1,28 +1,28 @@ ENV["RAILS_ENV"] ||= "test" -require 'stringio' -require 'active_support/testing/autorun' -require 'active_support/testing/stream' -require 'fileutils' +require "stringio" +require "active_support/testing/autorun" +require "active_support/testing/stream" +require "fileutils" -require 'active_support' -require 'action_controller' -require 'action_view' -require 'rails/all' +require "active_support" +require "action_controller" +require "action_view" +require "rails/all" module TestApp class Application < Rails::Application config.root = File.dirname(__FILE__) - secrets.secret_key_base = 'b3c631c314c0bbca50c1b2843150fe33' + secrets.secret_key_base = "b3c631c314c0bbca50c1b2843150fe33" end end # Skips the current run on Rubinius using Minitest::Assertions#skip -def rubinius_skip(message = '') - skip message if RUBY_ENGINE == 'rbx' +def rubinius_skip(message = "") + skip message if RUBY_ENGINE == "rbx" end # Skips the current run on JRuby using Minitest::Assertions#skip -def jruby_skip(message = '') +def jruby_skip(message = "") skip message if defined?(JRUBY_VERSION) end diff --git a/railties/test/app_loader_test.rb b/railties/test/app_loader_test.rb index 5946c8fd4c..7fd5c72c1c 100644 --- a/railties/test/app_loader_test.rb +++ b/railties/test/app_loader_test.rb @@ -1,6 +1,6 @@ -require 'tmpdir' -require 'abstract_unit' -require 'rails/app_loader' +require "tmpdir" +require "abstract_unit" +require "rails/app_loader" class AppLoaderTest < ActiveSupport::TestCase def loader @@ -27,12 +27,12 @@ class AppLoaderTest < ActiveSupport::TestCase end setup do - @tmp = Dir.mktmpdir('railties-rails-loader-test-suite') + @tmp = Dir.mktmpdir("railties-rails-loader-test-suite") @cwd = Dir.pwd Dir.chdir(@tmp) end - ['bin', 'script'].each do |script_dir| + ["bin", "script"].each do |script_dir| exe = "#{script_dir}/rails" test "is not in a Rails application if #{exe} is not found in the current or parent directories" do @@ -47,7 +47,7 @@ class AppLoaderTest < ActiveSupport::TestCase assert !loader.exec_app end - ['APP_PATH', 'ENGINE_PATH'].each do |keyword| + ["APP_PATH", "ENGINE_PATH"].each do |keyword| test "is in a Rails application if #{exe} exists and contains #{keyword}" do write exe, keyword @@ -66,7 +66,7 @@ class AppLoaderTest < ActiveSupport::TestCase write "foo/bar/#{exe}" write "foo/#{exe}", keyword - Dir.chdir('foo/bar') + Dir.chdir("foo/bar") loader.exec_app diff --git a/railties/test/application/asset_debugging_test.rb b/railties/test/application/asset_debugging_test.rb index 19327efcc8..ccecf2c09e 100644 --- a/railties/test/application/asset_debugging_test.rb +++ b/railties/test/application/asset_debugging_test.rb @@ -1,5 +1,5 @@ -require 'isolation/abstract_unit' -require 'rack/test' +require "isolation/abstract_unit" +require "rack/test" module ApplicationTests class AssetDebuggingTest < ActiveSupport::TestCase @@ -51,7 +51,7 @@ module ApplicationTests class ::PostsController < ActionController::Base ; end # the debug_assets params isn't used if compile is off - get '/posts?debug_assets=true' + get "/posts?debug_assets=true" assert_match(/