From 6bd812605de2e2360606be3821a046778b874254 Mon Sep 17 00:00:00 2001 From: tanraya Date: Sat, 21 Dec 2013 12:09:52 +0600 Subject: Use local variables in _form.html.erb generated by scaffold generator. It seems a good idea to use local variables in generated partials instead of using instance variables. Before <%= render 'form' %> After <%= render 'form', product: @product %> --- railties/test/generators/scaffold_generator_test.rb | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'railties/test') diff --git a/railties/test/generators/scaffold_generator_test.rb b/railties/test/generators/scaffold_generator_test.rb index 524bbde2b7..c44ce32122 100644 --- a/railties/test/generators/scaffold_generator_test.rb +++ b/railties/test/generators/scaffold_generator_test.rb @@ -68,6 +68,17 @@ class ScaffoldGeneratorTest < Rails::Generators::TestCase end assert_no_file "app/views/layouts/product_lines.html.erb" + # Views local variables + assert_file "app/views/product_lines/_form.html.erb" do |test| + assert_no_match(/@product_line/, test) + end + + %w(edit new).each do |view| + assert_file "app/views/product_lines/#{view}.html.erb" do |test| + assert_match(/product_line: @product_line/, test) + end + end + # Helpers assert_file "app/helpers/product_lines_helper.rb" assert_file "test/helpers/product_lines_helper_test.rb" -- cgit v1.2.3