From fd1c8c16c77c809098e85de960a7cde0a5025a68 Mon Sep 17 00:00:00 2001 From: bogdanvlviv Date: Fri, 6 Apr 2018 13:50:15 +0300 Subject: Fix test added in #32444 Currently test `#test_logger_does_not_mutate_app_return` doesn't test mutation of response and the test passes with and without changes added in #32444. `#freeze` response in the test in order to test mutation. --- railties/test/rack_logger_test.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'railties/test/rack_logger_test.rb') diff --git a/railties/test/rack_logger_test.rb b/railties/test/rack_logger_test.rb index 41e063e893..6e8f333e1d 100644 --- a/railties/test/rack_logger_test.rb +++ b/railties/test/rack_logger_test.rb @@ -81,11 +81,13 @@ module Rails end def test_logger_does_not_mutate_app_return - response = [] + response = [].freeze app = TestApp.new(response) logger = TestLogger.new(app: app) assert_no_changes("response") do - logger.call("REQUEST_METHOD" => "GET") + assert_nothing_raised do + logger.call("REQUEST_METHOD" => "GET") + end end end end -- cgit v1.2.3