From ff0d5f14504f1aa29ad908ab15bab66b101427b7 Mon Sep 17 00:00:00 2001 From: "yuuji.yaginuma" Date: Wed, 3 Jan 2018 08:00:27 +0900 Subject: Correctly get source location `filtered_results` returns an instance of `Minitest::Result` since https://github.com/seattlerb/minitest/commit/00433fc0a4fdd0e6b302aace633384ba13122376 `Minitest::Result` is not test class. So cannot get location directly. --- railties/lib/rails/test_unit/reporter.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'railties/lib/rails') diff --git a/railties/lib/rails/test_unit/reporter.rb b/railties/lib/rails/test_unit/reporter.rb index 7d3164f1eb..c8b7b70611 100644 --- a/railties/lib/rails/test_unit/reporter.rb +++ b/railties/lib/rails/test_unit/reporter.rb @@ -68,7 +68,12 @@ module Rails end def format_rerun_snippet(result) - location, line = result.method(result.name).source_location + location, line = if result.respond_to?(:source_location) + result.source_location + else + result.method(result.name).source_location + end + "#{executable} #{relative_path_for(location)}:#{line}" end -- cgit v1.2.3 From 76b75ac09406304e4d03f2d643b2ebd7bdaa6224 Mon Sep 17 00:00:00 2001 From: "yuuji.yaginuma" Date: Wed, 3 Jan 2018 11:19:22 +0900 Subject: Need to use `klass` to get the class name of the test result Ref: http://docs.seattlerb.org/minitest/Minitest/Result.html#attribute-i-klass --- railties/lib/rails/test_unit/reporter.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'railties/lib/rails') diff --git a/railties/lib/rails/test_unit/reporter.rb b/railties/lib/rails/test_unit/reporter.rb index c8b7b70611..28b93cee5a 100644 --- a/railties/lib/rails/test_unit/reporter.rb +++ b/railties/lib/rails/test_unit/reporter.rb @@ -64,7 +64,8 @@ module Rails end def format_line(result) - "%s#%s = %.2f s = %s" % [result.class, result.name, result.time, result.result_code] + klass = result.respond_to?(:klass) ? result.klass : result.class + "%s#%s = %.2f s = %s" % [klass, result.name, result.time, result.result_code] end def format_rerun_snippet(result) -- cgit v1.2.3