From 0d3b5fc0f5e1a208d0666985f68ed6418ba7e8b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Annie-Claude=20C=C3=B4t=C3=A9?= Date: Thu, 16 Aug 2018 10:50:37 -0400 Subject: Update 'rake initializers' to use Rails::Command under the hood * Invoke Rails::Command within the rake task * Adds test for calling initializers with 'bin/rake' * Adds deprecation warning to the rake task --- railties/lib/rails/tasks/initializers.rake | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'railties/lib/rails/tasks/initializers.rake') diff --git a/railties/lib/rails/tasks/initializers.rake b/railties/lib/rails/tasks/initializers.rake index ae85cb0f86..7ccf7455bb 100644 --- a/railties/lib/rails/tasks/initializers.rake +++ b/railties/lib/rails/tasks/initializers.rake @@ -1,8 +1,10 @@ # frozen_string_literal: true +require "rails/command" +require "active_support/deprecation" + desc "Print out all defined initializers in the order they are invoked by Rails." -task initializers: :environment do - Rails.application.initializers.tsort_each do |initializer| - puts "#{initializer.context_class}.#{initializer.name}" - end +task :initializers do + ActiveSupport::Deprecation.warn("Using `bin/rake initializers` is deprecated and will be removed in Rails 6.1. Use `bin/rails initializers` instead.\n") + Rails::Command.invoke "initializers" end -- cgit v1.2.3 From 63b9bf7d3dedd148e4d385bd948784429b5e0488 Mon Sep 17 00:00:00 2001 From: bogdanvlviv Date: Wed, 22 Aug 2018 20:49:37 +0300 Subject: Remove `rake initializers` from rake tasks list Context https://github.com/rails/rails/pull/33631#discussion_r210732565 --- railties/lib/rails/tasks/initializers.rake | 1 - 1 file changed, 1 deletion(-) (limited to 'railties/lib/rails/tasks/initializers.rake') diff --git a/railties/lib/rails/tasks/initializers.rake b/railties/lib/rails/tasks/initializers.rake index 7ccf7455bb..1fa8ca4f51 100644 --- a/railties/lib/rails/tasks/initializers.rake +++ b/railties/lib/rails/tasks/initializers.rake @@ -3,7 +3,6 @@ require "rails/command" require "active_support/deprecation" -desc "Print out all defined initializers in the order they are invoked by Rails." task :initializers do ActiveSupport::Deprecation.warn("Using `bin/rake initializers` is deprecated and will be removed in Rails 6.1. Use `bin/rails initializers` instead.\n") Rails::Command.invoke "initializers" -- cgit v1.2.3 From fb3642b0caf42b0554a8fd0672943f4da1643b2c Mon Sep 17 00:00:00 2001 From: "yuuji.yaginuma" Date: Sat, 1 Sep 2018 16:31:15 +0900 Subject: Respect config setting when output deprecation notice in rake tasks The rake tasks which became deprecate now does not load the environment. Therefore, even if the application specifies the behavior of deprecating, the message is output to stderr ignoring the specification. It seems that this is not the expected behavior. We should respect the setting even in the rake tasks. --- railties/lib/rails/tasks/initializers.rake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'railties/lib/rails/tasks/initializers.rake') diff --git a/railties/lib/rails/tasks/initializers.rake b/railties/lib/rails/tasks/initializers.rake index 1fa8ca4f51..f108517d1d 100644 --- a/railties/lib/rails/tasks/initializers.rake +++ b/railties/lib/rails/tasks/initializers.rake @@ -3,7 +3,7 @@ require "rails/command" require "active_support/deprecation" -task :initializers do +task initializers: :environment do ActiveSupport::Deprecation.warn("Using `bin/rake initializers` is deprecated and will be removed in Rails 6.1. Use `bin/rails initializers` instead.\n") Rails::Command.invoke "initializers" end -- cgit v1.2.3