From 4573fd2e06ee9b5a68f84f085f0a10c9ad6f129b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Thu, 25 Jun 2009 11:24:35 +0200 Subject: Added observer generator. --- .../lib/generators/rails/observer/observer_generator.rb | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 railties/lib/generators/rails/observer/observer_generator.rb (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb new file mode 100644 index 0000000000..9a5253a0ad --- /dev/null +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -0,0 +1,14 @@ +module Rails + module Generators + class ObserverGenerator < NamedBase + # TODO Check class collisions + # class_collisions "#{class_name}Observer", "#{class_name}ObserverTest" + + def create_observer_file + template 'observer.rb', File.join('app/models', class_path, "#{file_name}_observer.rb") + end + + add_and_invoke_test_framework_option! + end + end +end -- cgit v1.2.3 From ed33c29a4e2a07c2a738ec13775c5cc0d7867b50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Thu, 25 Jun 2009 11:56:18 +0200 Subject: Added class collision checks. --- railties/lib/generators/rails/observer/observer_generator.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index 9a5253a0ad..e5e1be39dc 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -1,8 +1,9 @@ module Rails module Generators class ObserverGenerator < NamedBase - # TODO Check class collisions - # class_collisions "#{class_name}Observer", "#{class_name}ObserverTest" + def check_class_collision + class_collisions "#{class_name}Observer" + end def create_observer_file template 'observer.rb', File.join('app/models', class_path, "#{file_name}_observer.rb") -- cgit v1.2.3 From 0bb95968db3695467b63357aab66a9dddb62295c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Thu, 25 Jun 2009 15:45:15 +0200 Subject: More code refactoring. --- railties/lib/generators/rails/observer/observer_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index e5e1be39dc..205ffc8064 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -9,7 +9,7 @@ module Rails template 'observer.rb', File.join('app/models', class_path, "#{file_name}_observer.rb") end - add_and_invoke_test_framework_option! + invoke_for :test_framework end end end -- cgit v1.2.3 From 2f3681dfc24e51698b9b900a5d03950da4508d2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Fri, 26 Jun 2009 10:40:02 +0200 Subject: Clean up class collisions check and a class method helper. --- railties/lib/generators/rails/observer/observer_generator.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index 205ffc8064..ad058a3172 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -1,9 +1,7 @@ module Rails module Generators class ObserverGenerator < NamedBase - def check_class_collision - class_collisions "#{class_name}Observer" - end + check_class_collision :suffix => "Observer" def create_observer_file template 'observer.rb', File.join('app/models', class_path, "#{file_name}_observer.rb") -- cgit v1.2.3 From ff48e23a4eb9f4a5fd3a02addb398499fb3c1455 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Sat, 27 Jun 2009 11:05:43 +0200 Subject: Make Observer generator agnostic. --- railties/lib/generators/rails/observer/observer_generator.rb | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index ad058a3172..b336cf41a0 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -1,13 +1,7 @@ module Rails module Generators class ObserverGenerator < NamedBase - check_class_collision :suffix => "Observer" - - def create_observer_file - template 'observer.rb', File.join('app/models', class_path, "#{file_name}_observer.rb") - end - - invoke_for :test_framework + invoke_for :orm, :test_framework end end end -- cgit v1.2.3 From 1a15dd4de577d77f37bc39a1ca59f871aa9a395b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Sat, 27 Jun 2009 14:27:26 +0200 Subject: Rename invoke_for to hook_for. --- railties/lib/generators/rails/observer/observer_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index b336cf41a0..e33247959b 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -1,7 +1,7 @@ module Rails module Generators class ObserverGenerator < NamedBase - invoke_for :orm, :test_framework + hook_for :orm, :test_framework end end end -- cgit v1.2.3 From 00b168e9d00033ac9ce470ecbf9b5460126efa5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Tue, 30 Jun 2009 09:29:26 +0200 Subject: Show second level invocations on usage. --- railties/lib/generators/rails/observer/observer_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index e33247959b..1d99f309e0 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -1,7 +1,7 @@ module Rails module Generators class ObserverGenerator < NamedBase - hook_for :orm, :test_framework + hook_for :orm end end end -- cgit v1.2.3 From 35c4df4aa5812abcd5928c31c1e673e32434b751 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Tue, 30 Jun 2009 10:20:11 +0200 Subject: Added scaffold_controller. --- railties/lib/generators/rails/observer/observer_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index 1d99f309e0..9332c3542a 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -1,6 +1,6 @@ module Rails module Generators - class ObserverGenerator < NamedBase + class ObserverGenerator < NamedBase #metagenerator hook_for :orm end end -- cgit v1.2.3 From 9541977e049d236564f34cf58660b61e154ccb32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Wed, 1 Jul 2009 13:30:07 +0200 Subject: Make scaffold controller generate agnostic code and mark some hooks as required. --- railties/lib/generators/rails/observer/observer_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'railties/lib/generators/rails/observer/observer_generator.rb') diff --git a/railties/lib/generators/rails/observer/observer_generator.rb b/railties/lib/generators/rails/observer/observer_generator.rb index 9332c3542a..f5cedee91f 100644 --- a/railties/lib/generators/rails/observer/observer_generator.rb +++ b/railties/lib/generators/rails/observer/observer_generator.rb @@ -1,7 +1,7 @@ module Rails module Generators class ObserverGenerator < NamedBase #metagenerator - hook_for :orm + hook_for :orm, :required => true end end end -- cgit v1.2.3