From 7d40aa4ddbf521d5e3bed9e63dc5a7f6fb45fe2b Mon Sep 17 00:00:00 2001 From: Xavier Noria Date: Thu, 6 Jun 2013 23:16:04 +0200 Subject: registers recent patch in the railties CHANGELOG --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index d11b0b7e85..23a7cf6ca3 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Clearing autoloaded constants triggers routes reloading [Fixes #10685]. + + *Xavier Noria* + * Fixes bug with scaffold generator with `--assets=false --resource-route=false`. Fixes #9525. -- cgit v1.2.3 From f0e4254bfa1443c3d51af117b925a02b88076f58 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C4=B1tk=C4=B1=20Ba=C4=9Fdat?= Date: Mon, 17 Jun 2013 03:22:31 +0300 Subject: Use Colspan in th Tags Is it more suitable that using `````` instead of three empty ``````? It is simple, but what i am missing about it? Change repetitive th tags to use colspan attribute Update CHANGELOG.md Update CHANGELOG.md --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 23a7cf6ca3..ae4bfc2447 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -12,5 +12,9 @@ moved to class methods in Railtie and the Railtie has been made abstract. *John Wang* + +* Changes repetitive th tags to use colspan attribute in `index.html.erb` template. + + *Sıtkı Bağdat* Please check [4-0-stable](https://github.com/rails/rails/blob/4-0-stable/railties/CHANGELOG.md) for previous changes. -- cgit v1.2.3 From 3e5dbda5bbcd0fdaa91b63fcfd22076c41b6a6db Mon Sep 17 00:00:00 2001 From: wangjohn Date: Wed, 26 Jun 2013 09:09:57 -0700 Subject: Removing deprecated rake tasks. The `rake test:recent` and `rake test:uncommitted` tasks were deprecated and are now being removed. --- railties/CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index ae4bfc2447..11927e7132 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,9 @@ +* Removed deprecated rake tasks. You will no longer be able to use the following + commands: `rake test:uncommitted` and `rake test:recent`. Also removed are + the tests for these rake tasks. + + *John Wang* + * Clearing autoloaded constants triggers routes reloading [Fixes #10685]. *Xavier Noria* -- cgit v1.2.3 From f5df6e5a6d5e6253708ea8cdb27ad675afea056c Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Wed, 26 Jun 2013 20:07:26 -0300 Subject: Review railties changelog [ci skip] --- railties/CHANGELOG.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 11927e7132..00ef1ad058 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,6 +1,5 @@ -* Removed deprecated rake tasks. You will no longer be able to use the following - commands: `rake test:uncommitted` and `rake test:recent`. Also removed are - the tests for these rake tasks. +* Removed deprecated rake tasks for running tests: `rake test:uncommitted` and + `rake test:recent`. *John Wang* @@ -18,9 +17,9 @@ moved to class methods in Railtie and the Railtie has been made abstract. *John Wang* - + * Changes repetitive th tags to use colspan attribute in `index.html.erb` template. - + *Sıtkı Bağdat* Please check [4-0-stable](https://github.com/rails/rails/blob/4-0-stable/railties/CHANGELOG.md) for previous changes. -- cgit v1.2.3 From e68183cccbfbefab66c2e74855f5b30525f8e902 Mon Sep 17 00:00:00 2001 From: Nikita Fedyashev Date: Fri, 28 Jun 2013 17:11:50 +0600 Subject: Omit turbolinks configuration completely on skip_javascript generator option --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 00ef1ad058..eb0545ccbf 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Omit turbolinks configuration completely on skip_javascript generator option. + + *Nikita Fedyashev* + * Removed deprecated rake tasks for running tests: `rake test:uncommitted` and `rake test:recent`. -- cgit v1.2.3 From 6ce18ba7dcce09401a3b80542a3f12b89e40ac98 Mon Sep 17 00:00:00 2001 From: schneems Date: Sat, 29 Jun 2013 12:54:23 +0300 Subject: Fix `rails plugin --help` Right now if you run the `rails plugin --help` command it fails because rails expects a command in `railties/lib/rails/commands/plugin.rb` that does not exist because the file is named `plugin_new`. This is the error: ``` ruby-2.0.0-p0 ~/documents/projects/tmp/vanilla (master) $ rails plugin --help /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `require': cannot load such file -- rails/commands/plugin (LoadError) from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `block in require' from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:213:in `load_dependency' from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/activesupport-4.0.0/lib/active_support/dependencies.rb:228:in `require' from /Users/schneems/.rvm/gems/ruby-2.0.0-p0/gems/railties-4.0.0/lib/rails/commands.rb:49:in `' from bin/rails:4:in `require' from bin/rails:4:in `
' ``` --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index eb0545ccbf..639dd70152 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Fix `rails plugin --help` command. + + *Richard Schneeman* + * Omit turbolinks configuration completely on skip_javascript generator option. *Nikita Fedyashev* -- cgit v1.2.3 From ec8d8652f36bc4bf2ea19b8f7dd264187efc99ae Mon Sep 17 00:00:00 2001 From: schneems Date: Mon, 1 Jul 2013 00:02:19 +0300 Subject: s/plugin_new/plugin There are historical reasons that the `plugin` command was `plugin_new`, now those are no longer applicable, we should remove the naming edge case from the project. This PR is based off of comments from #11176 ATP Railties --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 639dd70152..a7132d0a9a 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Rename `commands/plugin_new.rb` to `commands/plugin.rb` and fix references + + *Richard Schneeman* + * Fix `rails plugin --help` command. *Richard Schneeman* -- cgit v1.2.3 From d50483b04894b7c21b057bca7be7d0e857ae90ac Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Tue, 2 Jul 2013 09:25:08 +0530 Subject: Remove deprecated `config.whiny_nils` --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index a7132d0a9a..a3f5796b2c 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Remove deprecated `config.whiny_nils` option + + *Vipul A M* + * Rename `commands/plugin_new.rb` to `commands/plugin.rb` and fix references *Richard Schneeman* -- cgit v1.2.3 From 822d99562777f7d0ab2b79cacaec47690f6271e6 Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Wed, 3 Jul 2013 22:33:57 +0530 Subject: Remove deprecated `ActiveRecord::Generators::ActiveModel#update_attributes` in favor of `ActiveRecord::Generators::ActiveModel#update` --- railties/CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index a3f5796b2c..2fbdf6d12b 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,8 @@ +* Remove deprecated `ActiveRecord::Generators::ActiveModel#update_attributes` in + favor of `ActiveRecord::Generators::ActiveModel#update` + + *Vipul A M* + * Remove deprecated `config.whiny_nils` option *Vipul A M* -- cgit v1.2.3 From 7e897d469f29096ff9f893db851e1d4a7cc48482 Mon Sep 17 00:00:00 2001 From: Arun Agrawal Date: Wed, 3 Jul 2013 21:58:01 +0200 Subject: Added missing CHANGELOG from PR #11279 [ci skip] --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 2fbdf6d12b..2a0119a3b2 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Removed deprecated threadsafe! from Rails Config. + + *Paul Nikitochkin* + * Remove deprecated `ActiveRecord::Generators::ActiveModel#update_attributes` in favor of `ActiveRecord::Generators::ActiveModel#update` -- cgit v1.2.3 From 4a2a504f40a8b6eec88e6aafefcf8e579a24e1c9 Mon Sep 17 00:00:00 2001 From: Arun Agrawal Date: Thu, 4 Jul 2013 19:56:23 +0200 Subject: Removed deprecated `Rails.application.railties.engines`. --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 2a0119a3b2..b80aa944e0 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Removed deprecated `Rails.application.railties.engines`. + + *Arun Agrawal* + * Removed deprecated threadsafe! from Rails Config. *Paul Nikitochkin* -- cgit v1.2.3 From dd996ad394057a003ad851ff75e6242d0c5e8fa1 Mon Sep 17 00:00:00 2001 From: Yuri Artemev Date: Mon, 8 Jul 2013 19:13:01 +0400 Subject: handle notes in *.sass files --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index b80aa944e0..cc7fecb28a 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Fix `rake notes` to look into `*.sass` files + + *Yuri Artemev* + * Removed deprecated `Rails.application.railties.engines`. *Arun Agrawal* -- cgit v1.2.3 From 9cac69c602f57e397fe01d866cb24ce1781606d4 Mon Sep 17 00:00:00 2001 From: Paul Nikitochkin Date: Tue, 9 Jul 2013 23:36:50 +0300 Subject: #11381: Ignore config.eager_load=true for rake Closes #11381 --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index cc7fecb28a..13a3301fbd 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Fix `rake environment` to do not eager load modules + + *Paul Nikitochkin* + * Fix `rake notes` to look into `*.sass` files *Yuri Artemev* -- cgit v1.2.3 From 8e1656e76f048893c552358fe02153b758c854e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josef=20=C5=A0im=C3=A1nek?= Date: Sat, 13 Jul 2013 14:30:58 +0200 Subject: Remove update:application_controller rake task. --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 13a3301fbd..e4ed59e58c 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Removed `update:application_controller` rake task. + + *Josef Šimánek* + * Fix `rake environment` to do not eager load modules *Paul Nikitochkin* -- cgit v1.2.3 From 5ecd125a62da693320da8ea7bbccd60b71f67e63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josef=20=C5=A0im=C3=A1nek?= Date: Sat, 13 Jul 2013 12:49:31 +0200 Subject: Added generated unit test for generator generator and new test:generators rake task included in test:all rake task. --- railties/CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index e4ed59e58c..7e7b157483 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,8 @@ +* Added generated unit test for generator generator using new + `test:generators` rake task. + + *Josef Šimánek* + * Removed `update:application_controller` rake task. *Josef Šimánek* -- cgit v1.2.3 From f18aecfe7b70849f2f73da329a6a14260cea6edd Mon Sep 17 00:00:00 2001 From: Pawel Janiak Date: Sun, 28 Jul 2013 15:05:17 +0200 Subject: Changed stylesheet load order in the stylesheet manifest generator. --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 7e7b157483..dd357bfbc5 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -68,4 +68,8 @@ *Sıtkı Bağdat* +* Changed stylesheet load order in the stylesheet manifest generator. [Fixes #11639] + + *Pawel Janiak* + Please check [4-0-stable](https://github.com/rails/rails/blob/4-0-stable/railties/CHANGELOG.md) for previous changes. -- cgit v1.2.3 From 4cf805a6d98f372148755b36153d4267889aa67f Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Mon, 29 Jul 2013 08:03:41 -0300 Subject: Move changelog entry to the top [ci skip] --- railties/CHANGELOG.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index dd357bfbc5..30328a0c19 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,8 @@ +* Changed stylesheet load order in the stylesheet manifest generator. + Fixes #11639. + + *Pawel Janiak* + * Added generated unit test for generator generator using new `test:generators` rake task. @@ -49,7 +54,8 @@ *John Wang* -* Clearing autoloaded constants triggers routes reloading [Fixes #10685]. +* Clearing autoloaded constants triggers routes reloading. + Fixes #10685. *Xavier Noria* @@ -68,8 +74,4 @@ *Sıtkı Bağdat* -* Changed stylesheet load order in the stylesheet manifest generator. [Fixes #11639] - - *Pawel Janiak* - Please check [4-0-stable](https://github.com/rails/rails/blob/4-0-stable/railties/CHANGELOG.md) for previous changes. -- cgit v1.2.3 From 3a7e321246a8d1a4058b4c0ad5205cfc141e0cfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?= Date: Sun, 4 Aug 2013 11:38:14 -0300 Subject: Add CHANGELOG entry for #11665 [ci skip] --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 30328a0c19..1965d09297 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Make `config.log_level` work with custom loggers. + + *Max Shytikov* + * Changed stylesheet load order in the stylesheet manifest generator. Fixes #11639. -- cgit v1.2.3 From d86ccec0979ad60c2430a40864e90dc2f14fd2cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?= Date: Mon, 5 Aug 2013 18:16:41 -0300 Subject: Use the right instrumentation name The pattern is event.component Closes #11769 Conflicts: railties/CHANGELOG.md --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 1965d09297..7a89e5c219 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* Fix the event name of action_dispatch requests. + + *Rafael Mendonça França* + * Make `config.log_level` work with custom loggers. *Max Shytikov* -- cgit v1.2.3 From 53c5794a4bb7a1bc8b3cbe9bae86c35de06c5088 Mon Sep 17 00:00:00 2001 From: Prathamesh Sonpatki Date: Sun, 21 Jul 2013 20:36:35 +0530 Subject: Generate namespaced routes correctly for generators. Fix for #11532 --- railties/CHANGELOG.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 7a89e5c219..2f41d92f55 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,21 @@ +* Generate nested route for namespaced controller generated using + `rails g controller`. + Fixes #11532. + + Example: + + rails g controller admin/dashboard index + + # Before: + get "dashboard/index" + + # After: + namespace :admin do + get "dashboard/index" + end + + *Prathamesh Sonpatki* + * Fix the event name of action_dispatch requests. *Rafael Mendonça França* -- cgit v1.2.3 From f3073773a31d2a6a4f3946dc706a31400c0f53a0 Mon Sep 17 00:00:00 2001 From: Josh Crowder Date: Thu, 15 Aug 2013 11:30:01 +0100 Subject: Adding LESS to rake notes --- railties/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 2f41d92f55..cc9722e59c 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,7 @@ +* rake notes now searches *.less files + + *Josh Crowder* + * Generate nested route for namespaced controller generated using `rails g controller`. Fixes #11532. -- cgit v1.2.3 From 47ac67b8d4f77e22ce1cae5c7bf836b0d6325d1e Mon Sep 17 00:00:00 2001 From: Piotr Sarnacki Date: Sat, 7 Sep 2013 22:50:54 +0200 Subject: Don't require using application_name before options Before this commit options for `rails new` and `rails plugin new` had to be passed in a strict order, trying to execute a following command: rails new -J path/to/app resulted in an error. This commit fixes the situation and allows to pass path to app anywhere after `new` --- railties/CHANGELOG.md | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) (limited to 'railties/CHANGELOG.md') diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index cc9722e59c..797cffc884 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -1,3 +1,8 @@ +* Don't require passing path to app before options in `rails new` + and `rails plugin new` + + *Piotr Sarnacki* + * rake notes now searches *.less files *Josh Crowder* @@ -5,21 +10,21 @@ * Generate nested route for namespaced controller generated using `rails g controller`. Fixes #11532. - + Example: - + rails g controller admin/dashboard index - + # Before: get "dashboard/index" - + # After: namespace :admin do get "dashboard/index" end - + *Prathamesh Sonpatki* - + * Fix the event name of action_dispatch requests. *Rafael Mendonça França* -- cgit v1.2.3 From 5f98bb402b657f785e6bf1a49e83d44c6d3aa062 Mon Sep 17 00:00:00 2001 From: schneems Date: Tue, 18 Jun 2013 15:24:00 -0500 Subject: Only output Server logs in Development Right now when you start a server via `rails s`, the logger gets extended so that it logs to the file system and also to stdout. This extension behavior is not "intelligent" and if the default logger is already set to output to stdout, then the contents will be received twice. To capture logs in accordance with http://www.12factor.net/logs some platforms require the logs to be sent to standard out. If a logger is set to stdout, and the server is started using `rails server` instead of another method (i.e. `thin start` etc.) then the app will produce double logs. This PR fixes the issue by only extending the logger to standard out in the development environment. So that in production you don't get double logs like this: ``` ActionView::Template::Error (wrong number of arguments (5 for 4)): 1: <% lang_index = 0 %> 2:
3: