From d51697d2bd2cdd6394cb5e665aab8ab43ce9a14a Mon Sep 17 00:00:00 2001 From: Emilio Tagua Date: Thu, 18 Feb 2010 18:28:27 -0300 Subject: Added support for RETURNING primary key when available, only for PostgreSQL. --- lib/arel/engines/sql/compilers/postgresql_compiler.rb | 4 ++++ lib/arel/engines/sql/engine.rb | 2 +- lib/arel/engines/sql/relations/compiler.rb | 4 ++++ lib/arel/engines/sql/relations/writes.rb | 3 ++- 4 files changed, 11 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/arel/engines/sql/compilers/postgresql_compiler.rb b/lib/arel/engines/sql/compilers/postgresql_compiler.rb index 4122bc730e..1f6e74d57a 100644 --- a/lib/arel/engines/sql/compilers/postgresql_compiler.rb +++ b/lib/arel/engines/sql/compilers/postgresql_compiler.rb @@ -33,6 +33,10 @@ module Arel order = orders.join(', ').split(/,/).map { |s| s.strip }.reject(&:blank?) order = order.zip((0...order.size).to_a).map { |s,i| "id_list.alias_#{i} #{'DESC' if s =~ /\bdesc$/i}" }.join(', ') end + + def supports_insert_with_returning? + engine.postgresql_version >= 80200 + end end end end diff --git a/lib/arel/engines/sql/engine.rb b/lib/arel/engines/sql/engine.rb index 82915fe890..79011a3db5 100644 --- a/lib/arel/engines/sql/engine.rb +++ b/lib/arel/engines/sql/engine.rb @@ -20,7 +20,7 @@ module Arel module CRUD def create(relation) - connection.insert(relation.to_sql, nil, relation.primary_key) + connection.execute(relation.to_sql) end def read(relation) diff --git a/lib/arel/engines/sql/relations/compiler.rb b/lib/arel/engines/sql/relations/compiler.rb index 4bc169096a..185f1a5c87 100644 --- a/lib/arel/engines/sql/relations/compiler.rb +++ b/lib/arel/engines/sql/relations/compiler.rb @@ -26,6 +26,10 @@ module Arel "WHERE #{quoted_primary_key} IN (SELECT #{quoted_primary_key} FROM #{engine.connection.quote_table_name table.name} #{conditions})" end + def supports_insert_with_returning? + false + end + protected def method_missing(method, *args, &block) relation.send(method, *args, &block) diff --git a/lib/arel/engines/sql/relations/writes.rb b/lib/arel/engines/sql/relations/writes.rb index 30b36ddda8..00cd61cdde 100644 --- a/lib/arel/engines/sql/relations/writes.rb +++ b/lib/arel/engines/sql/relations/writes.rb @@ -32,7 +32,8 @@ module Arel build_query \ "INSERT", "INTO #{table_sql}", - insertion_attributes_values_sql + insertion_attributes_values_sql, + ("RETURNING #{engine.quote_column_name(primary_key)}" if compiler.supports_insert_with_returning?) end end -- cgit v1.2.3