From a4f36f957e013f6da34e04f0d3f1d86d86491454 Mon Sep 17 00:00:00 2001
From: Kasper Timm Hansen <kaspth@gmail.com>
Date: Sun, 23 Jul 2017 21:41:16 +0200
Subject: Fix attaching with standard Rails associations.

Removes needless ivar caching (a Rails association handles that).

Inserts a reload and a nil assign, since the association proxy doesn't
seem to that it's been destroyed through `purge`.
---
 lib/active_storage/attached/many.rb |  9 ++++-----
 lib/active_storage/attached/one.rb  | 13 +++++++++----
 2 files changed, 13 insertions(+), 9 deletions(-)

(limited to 'lib')

diff --git a/lib/active_storage/attached/many.rb b/lib/active_storage/attached/many.rb
index 129f166776..704369ba89 100644
--- a/lib/active_storage/attached/many.rb
+++ b/lib/active_storage/attached/many.rb
@@ -7,15 +7,15 @@ class ActiveStorage::Attached::Many < ActiveStorage::Attached
   # You don't have to call this method to access the attachments' methods as
   # they are all available at the model level.
   def attachments
-    @attachments ||= record.public_send("#{name}_attachments")
+    record.public_send("#{name}_attachments")
   end
 
   # Associates one or several attachments with the current record, saving
   # them to the database.
   def attach(*attachables)
-    @attachments = attachments | Array(attachables).flatten.collect do |attachable|
+    record.public_send("#{name}_attachments=", attachments | Array(attachables).flat_map do |attachable|
       ActiveStorage::Attachment.create!(record: record, name: name, blob: create_blob_from(attachable))
-    end
+    end)
   end
 
   # Checks the presence of attachments.
@@ -34,7 +34,7 @@ class ActiveStorage::Attached::Many < ActiveStorage::Attached
   def purge
     if attached?
       attachments.each(&:purge)
-      @attachments = nil
+      attachments.reload
     end
   end
 
@@ -42,7 +42,6 @@ class ActiveStorage::Attached::Many < ActiveStorage::Attached
   def purge_later
     if attached?
       attachments.each(&:purge_later)
-      @attachments = nil
     end
   end
 end
diff --git a/lib/active_storage/attached/one.rb b/lib/active_storage/attached/one.rb
index 02fc9c9abc..d255412842 100644
--- a/lib/active_storage/attached/one.rb
+++ b/lib/active_storage/attached/one.rb
@@ -7,13 +7,14 @@ class ActiveStorage::Attached::One < ActiveStorage::Attached
   # You don't have to call this method to access the attachment's methods as
   # they are all available at the model level.
   def attachment
-    @attachment ||= record.public_send("#{name}_attachment")
+    record.public_send("#{name}_attachment")
   end
 
   # Associates a given attachment with the current record, saving it to the
   # database.
   def attach(attachable)
-    @attachment = ActiveStorage::Attachment.create!(record: record, name: name, blob: create_blob_from(attachable))
+    write_attachment \
+      ActiveStorage::Attachment.create!(record: record, name: name, blob: create_blob_from(attachable))
   end
 
   # Checks the presence of the attachment.
@@ -32,7 +33,7 @@ class ActiveStorage::Attached::One < ActiveStorage::Attached
   def purge
     if attached?
       attachment.purge
-      @attachment = nil
+      write_attachment nil
     end
   end
 
@@ -40,7 +41,11 @@ class ActiveStorage::Attached::One < ActiveStorage::Attached
   def purge_later
     if attached?
       attachment.purge_later
-      @attachment = nil
     end
   end
+
+  private
+    def write_attachment(attachment)
+      record.public_send("#{name}_attachment=", attachment)
+    end
 end
-- 
cgit v1.2.3