From a8f6662defe086258814f82dc8acb8d2eeee9842 Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Sun, 14 Jul 2013 21:15:09 +0530 Subject: Remove deprecated calls to `SelectManage#insert` with preference to using `compile_insert` --- lib/arel/select_manager.rb | 25 ------------------------- 1 file changed, 25 deletions(-) (limited to 'lib/arel') diff --git a/lib/arel/select_manager.rb b/lib/arel/select_manager.rb index 399cddb513..b4899177d5 100644 --- a/lib/arel/select_manager.rb +++ b/lib/arel/select_manager.rb @@ -264,31 +264,6 @@ module Arel @engine.connection.send(:select, to_sql, 'AREL').map { |x| Row.new(x) } end - # FIXME: this method should go away - def insert values - if $VERBOSE - warn <<-eowarn -insert (#{caller.first}) is deprecated and will be removed in Arel 4.0.0. Please -switch to `compile_insert` - eowarn - end - - im = compile_insert(values) - table = @ctx.froms - - primary_key = table.primary_key - primary_key_name = primary_key.name if primary_key - - # FIXME: in AR tests values sometimes were Array and not Hash therefore is_a?(Hash) check is added - primary_key_value = primary_key && values.is_a?(Hash) && values[primary_key] - im.into table - # Oracle adapter needs primary key name to generate RETURNING ... INTO ... clause - # for tables which assign primary key value using trigger. - # RETURNING ... INTO ... clause will be added only if primary_key_value is nil - # therefore it is necessary to pass primary key value as well - @engine.connection.insert im.to_sql, 'AREL', primary_key_name, primary_key_value - end - private def collapse exprs, existing = nil exprs = exprs.unshift(existing.expr) if existing -- cgit v1.2.3