From a4a33fbb0a2375bfb13795148c17d460f3c5338d Mon Sep 17 00:00:00 2001 From: Alex Lin Date: Tue, 25 Mar 2014 13:28:09 -0400 Subject: remove the default parameter and updated comment --- lib/arel/visitors/dot.rb | 4 ++-- lib/arel/visitors/oracle.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/arel/visitors') diff --git a/lib/arel/visitors/dot.rb b/lib/arel/visitors/dot.rb index d5033d166d..b2fa6bfbd5 100644 --- a/lib/arel/visitors/dot.rb +++ b/lib/arel/visitors/dot.rb @@ -202,7 +202,7 @@ module Arel def visit_Hash o o.each_with_index do |pair, i| - edge("pair_#{i}") { visit pair, a } + edge("pair_#{i}") { visit pair } end end @@ -216,7 +216,7 @@ module Arel edge(method) { visit o.send(method) } end - def visit o = nil + def visit o if node = @seen[o.object_id] @edge_stack.last.to = node return diff --git a/lib/arel/visitors/oracle.rb b/lib/arel/visitors/oracle.rb index 0b5f19baa1..0cd0179931 100644 --- a/lib/arel/visitors/oracle.rb +++ b/lib/arel/visitors/oracle.rb @@ -89,7 +89,7 @@ module Arel # Previous version with join and split broke ORDER BY clause # if it contained functions with several arguments (separated by ','). # - # orders = o.orders.map { |x| visit x, a }.join(', ').split(',') + # orders = o.orders.map { |x| visit x }.join(', ').split(',') orders = o.orders.map do |x| string = visit x if string.include?(',') -- cgit v1.2.3