From 8c73dad0761980061ce45018172034cad34cd585 Mon Sep 17 00:00:00 2001 From: Tamir Duberstein Date: Sat, 13 Sep 2014 19:35:34 -0700 Subject: `Extract#as` should not mutate the receiver Fixes https://github.com/rails/rails/issues/16913 --- lib/arel/visitors/to_sql.rb | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'lib/arel/visitors') diff --git a/lib/arel/visitors/to_sql.rb b/lib/arel/visitors/to_sql.rb index ae1b7930af..ca09373b64 100644 --- a/lib/arel/visitors/to_sql.rb +++ b/lib/arel/visitors/to_sql.rb @@ -475,14 +475,7 @@ module Arel def visit_Arel_Nodes_Extract o, collector collector << "EXTRACT(#{o.field.to_s.upcase} FROM " - collector = visit o.expr, collector - collector << ")" - if o.alias - collector << " AS " - visit o.alias, collector - else - collector - end + visit(o.expr, collector) << ")" end def visit_Arel_Nodes_Count o, collector -- cgit v1.2.3