From e619462165bfab5bee85f9761df7f48a6b8f30f0 Mon Sep 17 00:00:00 2001 From: Raimonds Simanovskis Date: Wed, 29 Sep 2010 13:10:17 +0300 Subject: use subquery for limit when DISTINCT is used (in Oracle) --- lib/arel/visitors/oracle.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'lib/arel/visitors/oracle.rb') diff --git a/lib/arel/visitors/oracle.rb b/lib/arel/visitors/oracle.rb index 659b75f16d..c691ce294e 100644 --- a/lib/arel/visitors/oracle.rb +++ b/lib/arel/visitors/oracle.rb @@ -6,7 +6,9 @@ module Arel def visit_Arel_Nodes_SelectStatement o o = order_hacks(o) - if o.limit && o.orders.empty? && !o.offset + # if need to select first records without ORDER BY and GROUP BY and without DISTINCT + # then can use simple ROWNUM in WHERE clause + if o.limit && o.orders.empty? && !o.offset && o.cores.first.projections.first !~ /^DISTINCT / o.cores.last.wheres.push Nodes::LessThanOrEqual.new( Nodes::SqlLiteral.new('ROWNUM'), o.limit ) @@ -31,7 +33,7 @@ module Arel eosql end - if o.limit && !o.orders.empty? + if o.limit o = o.dup limit = o.limit o.limit = nil -- cgit v1.2.3