From 4e1dd7eeabde2bd785d47db895e45c11f1693c05 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Mon, 30 Aug 2010 18:35:13 -0400 Subject: deep copies of statements aren't necessary. shallow copy the top-level arrays. --- lib/arel/nodes/delete_statement.rb | 2 +- lib/arel/nodes/insert_statement.rb | 4 ++-- lib/arel/nodes/select_core.rb | 6 +++--- lib/arel/nodes/select_statement.rb | 2 +- lib/arel/nodes/update_statement.rb | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) (limited to 'lib/arel/nodes') diff --git a/lib/arel/nodes/delete_statement.rb b/lib/arel/nodes/delete_statement.rb index b65177af05..610d69e460 100644 --- a/lib/arel/nodes/delete_statement.rb +++ b/lib/arel/nodes/delete_statement.rb @@ -10,7 +10,7 @@ module Arel def initialize_copy other super - @wheres = @wheres.map { |o| o.clone } + @wheres = @wheres.clone end end end diff --git a/lib/arel/nodes/insert_statement.rb b/lib/arel/nodes/insert_statement.rb index 8c6e1234d0..629e7a8513 100644 --- a/lib/arel/nodes/insert_statement.rb +++ b/lib/arel/nodes/insert_statement.rb @@ -11,8 +11,8 @@ module Arel def initialize_copy other super - @columns = @columns.map { |o| o.clone } - @values = @values.map { |o| o.clone } + @columns = @columns.clone + @values = @values.clone end end end diff --git a/lib/arel/nodes/select_core.rb b/lib/arel/nodes/select_core.rb index 7ebdab315d..5e27c7c414 100644 --- a/lib/arel/nodes/select_core.rb +++ b/lib/arel/nodes/select_core.rb @@ -11,9 +11,9 @@ module Arel def initialize_copy other super - @froms = @froms.map { |o| o.clone } - @projections = @projections.map { |o| o.clone } - @wheres = @wheres.map { |o| o.clone } + @froms = @froms.clone + @projections = @projections.clone + @wheres = @wheres.clone end end end diff --git a/lib/arel/nodes/select_statement.rb b/lib/arel/nodes/select_statement.rb index d00a079dc3..b7c59da275 100644 --- a/lib/arel/nodes/select_statement.rb +++ b/lib/arel/nodes/select_statement.rb @@ -12,7 +12,7 @@ module Arel def initialize_copy other super - @cores = @cores.map { |o| o.clone } + @cores = @cores.clone end end end diff --git a/lib/arel/nodes/update_statement.rb b/lib/arel/nodes/update_statement.rb index 27e3e4e6ac..7a1ce9a7b1 100644 --- a/lib/arel/nodes/update_statement.rb +++ b/lib/arel/nodes/update_statement.rb @@ -11,8 +11,8 @@ module Arel def initialize_copy other super - @wheres = @wheres.map { |o| o.clone } - @values = @values.map { |o| o.clone } + @wheres = @wheres.clone + @values = @values.clone end end end -- cgit v1.2.3