From 5afed6d45def1e72df24679a746cbe96b52c1709 Mon Sep 17 00:00:00 2001 From: Ernie Miller Date: Sat, 24 Apr 2010 08:02:47 -0400 Subject: Inequality shouldn't descend from equality, due to Rails type checks, and resolve conflicts from rebase --- lib/arel/engines/sql/core_extensions/nil_class.rb | 4 ---- lib/arel/engines/sql/core_extensions/object.rb | 4 ---- lib/arel/engines/sql/predicates.rb | 2 +- lib/arel/engines/sql/primitives.rb | 4 ---- 4 files changed, 1 insertion(+), 13 deletions(-) (limited to 'lib/arel/engines/sql') diff --git a/lib/arel/engines/sql/core_extensions/nil_class.rb b/lib/arel/engines/sql/core_extensions/nil_class.rb index d4bb0e4c33..ab990d6211 100644 --- a/lib/arel/engines/sql/core_extensions/nil_class.rb +++ b/lib/arel/engines/sql/core_extensions/nil_class.rb @@ -9,10 +9,6 @@ module Arel 'IS NOT' end - def not_predicate_sql - 'IS NOT' - end - NilClass.send(:include, self) end end diff --git a/lib/arel/engines/sql/core_extensions/object.rb b/lib/arel/engines/sql/core_extensions/object.rb index 5415c84706..01c3c5479d 100644 --- a/lib/arel/engines/sql/core_extensions/object.rb +++ b/lib/arel/engines/sql/core_extensions/object.rb @@ -13,10 +13,6 @@ module Arel '!=' end - def not_predicate_sql - '!=' - end - Object.send(:include, self) end end diff --git a/lib/arel/engines/sql/predicates.rb b/lib/arel/engines/sql/predicates.rb index df8700a500..59b0ab0929 100644 --- a/lib/arel/engines/sql/predicates.rb +++ b/lib/arel/engines/sql/predicates.rb @@ -52,7 +52,7 @@ module Arel end end - class Inequality < Equality + class Inequality < Binary def predicate_sql operand2.inequality_predicate_sql end diff --git a/lib/arel/engines/sql/primitives.rb b/lib/arel/engines/sql/primitives.rb index 41769fa510..15a27b2256 100644 --- a/lib/arel/engines/sql/primitives.rb +++ b/lib/arel/engines/sql/primitives.rb @@ -42,10 +42,6 @@ module Arel value.inequality_predicate_sql end - def not_predicate_sql - value.not_predicate_sql - end - def to_sql(formatter = Sql::WhereCondition.new(relation)) formatter.value value end -- cgit v1.2.3