From afb7047e52dd6dae160b60b74a0c7efaf536933c Mon Sep 17 00:00:00 2001 From: Chris Smith Date: Wed, 12 Jul 2017 10:01:12 -0600 Subject: Update GCSService#url Update google-cloud-storage dependency to 1.3 Refactor arguments to Google::Cloud::Storage::File#signed_url --- lib/active_storage/service/gcs_service.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/active_storage/service') diff --git a/lib/active_storage/service/gcs_service.rb b/lib/active_storage/service/gcs_service.rb index bca4ab5331..0bcd29cab8 100644 --- a/lib/active_storage/service/gcs_service.rb +++ b/lib/active_storage/service/gcs_service.rb @@ -44,8 +44,8 @@ class ActiveStorage::Service::GCSService < ActiveStorage::Service def url(key, expires_in:, disposition:, filename:) instrument :url, key do |payload| - generated_url = file_for(key).signed_url(expires: expires_in) + "&" + - { "response-content-disposition" => "#{disposition}; filename=\"#{filename}\"" }.to_query + query = { "response-content-disposition" => "#{disposition}; filename=\"#{filename}\"" } + generated_url = file_for(key).signed_url(expires: expires_in, query: query) payload[:url] = generated_url -- cgit v1.2.3