From 2592e22ab7a5025a473139048674e687423bde46 Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Tue, 7 Jun 2016 17:34:28 -0700 Subject: Expand on AC introduction list [ci skip] --- guides/source/action_cable_overview.md | 2 ++ 1 file changed, 2 insertions(+) (limited to 'guides/source') diff --git a/guides/source/action_cable_overview.md b/guides/source/action_cable_overview.md index 16aa9438a2..f37be6474b 100644 --- a/guides/source/action_cable_overview.md +++ b/guides/source/action_cable_overview.md @@ -6,8 +6,10 @@ incorporate real-time features into your Rails application. After reading this guide, you will know: +* What Action Cable is and its integration on backend and frontend * How to setup Action Cable * How to setup channels +* Deployment and Architecture setup for running Action Cable Introduction ------------ -- cgit v1.2.3 From f9a29680682fe8c84ea634157927b9826cbf669f Mon Sep 17 00:00:00 2001 From: Prathamesh Sonpatki Date: Fri, 10 Jun 2016 15:29:51 -0700 Subject: Action Cable routes are enabled by default now [ci skip] - Followup of https://github.com/rails/rails/commit/8b69f1eeba753c38364fb88136b2503480f2de1d. --- guides/source/getting_started.md | 5 ----- 1 file changed, 5 deletions(-) (limited to 'guides/source') diff --git a/guides/source/getting_started.md b/guides/source/getting_started.md index 65fdd7ca0d..e0832a32a6 100644 --- a/guides/source/getting_started.md +++ b/guides/source/getting_started.md @@ -299,9 +299,6 @@ Rails.application.routes.draw do get 'welcome/index' # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html - - # Serve websocket cable requests in-process - # mount ActionCable.server => '/cable' end ``` @@ -318,8 +315,6 @@ Rails.application.routes.draw do # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html - # Serve websocket cable requests in-process - # mount ActionCable.server => '/cable' root 'welcome#index' end ``` -- cgit v1.2.3 From d66a3fe8c0b5977c8c7bbff878b549fb4f01a95c Mon Sep 17 00:00:00 2001 From: Prathamesh Sonpatki Date: Wed, 15 Jun 2016 20:35:16 -0700 Subject: [ci skip] When instance_reader is false, attribute can still be assigned by the instance objects --- guides/source/active_support_core_extensions.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'guides/source') diff --git a/guides/source/active_support_core_extensions.md b/guides/source/active_support_core_extensions.md index 565c87c4b5..e0b6f2f820 100644 --- a/guides/source/active_support_core_extensions.md +++ b/guides/source/active_support_core_extensions.md @@ -954,7 +954,8 @@ class A class_attribute :x, instance_reader: false end -A.new.x = 1 # NoMethodError +A.new.x = 1 +A.new.x # NoMethodError ``` For convenience `class_attribute` also defines an instance predicate which is the double negation of what the instance reader returns. In the examples above it would be called `x?`. -- cgit v1.2.3 From 87d80ba976e4999808dcddb09aeb61766e0d8cca Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Wed, 15 Jun 2016 21:57:09 -0700 Subject: Make log tags example for ACa more generic and not BC specific [ci skip] --- guides/source/action_cable_overview.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'guides/source') diff --git a/guides/source/action_cable_overview.md b/guides/source/action_cable_overview.md index f37be6474b..2308befd12 100644 --- a/guides/source/action_cable_overview.md +++ b/guides/source/action_cable_overview.md @@ -570,12 +570,13 @@ environment configuration files. ### Other Configurations -The other common option to configure is the log tags applied to the -per-connection logger. Here's close to what we're using in Basecamp: +The other common option to configure, is the log tags applied to the +per-connection logger. Here's an example that uses +the user account id if available, else "no-account" while tagging: ```ruby config.action_cable.log_tags = [ - -> request { request.env['bc.account_id'] || "no-account" }, + -> request { request.env['user_account_id'] || "no-account" }, :action_cable, -> request { request.uuid } ] -- cgit v1.2.3