From 41381c19d1f3920ee9540aff0d35209cb43fb057 Mon Sep 17 00:00:00 2001 From: Ace Suares Date: Mon, 24 Dec 2012 08:14:14 -0400 Subject: reminder to run bundle after setting up rails-dev-box --- guides/source/contributing_to_ruby_on_rails.md | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'guides/source') diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index ce2a5a4902..59c200fe0c 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -49,6 +49,13 @@ To move on from submitting bugs to helping resolve existing issues or contributi The easiest and recommended way to get a development environment ready to hack is to use the [Rails development box](https://github.com/rails/rails-dev-box). +After you have setup your Rails development box and cloned your Rails fork on the host computer, don't forget to run Bundler before you start testing. + + host $ vagrant ssh + Welcome to Ubuntu 12.04 LTS... + ... + vagrant@rails-dev-box:~$ cd /vagrant/rails && bundle install + ### The Hard Way In case you can't use the Rails development box, see section above, check [this other guide](development_dependencies_install.html). -- cgit v1.2.3 From 52691c369c559d726d94d8551b5b809621e31a84 Mon Sep 17 00:00:00 2001 From: Colin Kelley Date: Wed, 26 Dec 2012 17:02:54 -0800 Subject: removed TIP: :allow_nil/:allow_blank is ignored by the presence validator These tips were documenting an inconsistency issue https://github.com/rails/rails/issues/8621. That issue is resolved by https://github.com/rails/rails/issues/8622. --- guides/source/active_record_validations.md | 4 ---- 1 file changed, 4 deletions(-) (limited to 'guides/source') diff --git a/guides/source/active_record_validations.md b/guides/source/active_record_validations.md index 822d12aa3a..5797c93ae7 100644 --- a/guides/source/active_record_validations.md +++ b/guides/source/active_record_validations.md @@ -656,8 +656,6 @@ class Coffee < ActiveRecord::Base end ``` -TIP: `:allow_nil` is ignored by the presence validator. - ### `:allow_blank` The `:allow_blank` option is similar to the `:allow_nil` option. This option @@ -673,8 +671,6 @@ Topic.create("title" => "").valid? # => true Topic.create("title" => nil).valid? # => true ``` -TIP: `:allow_blank` is ignored by the presence validator. - ### `:message` As you've already seen, the `:message` option lets you specify the message that -- cgit v1.2.3 From e63b752f635f62e22859e034a55d7918945c3961 Mon Sep 17 00:00:00 2001 From: Fabrizio Regini Date: Thu, 27 Dec 2012 18:11:21 +0100 Subject: Fixed couple of typos --- guides/source/active_support_instrumentation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'guides/source') diff --git a/guides/source/active_support_instrumentation.md b/guides/source/active_support_instrumentation.md index cf5a51fc5b..6b3be69942 100644 --- a/guides/source/active_support_instrumentation.md +++ b/guides/source/active_support_instrumentation.md @@ -432,7 +432,7 @@ from block args like this: ```ruby ActiveSupport::Notifications.subscribe "process_action.action_controller" do |*args| - event = ActiveSupport::Notification::Event.new args + event = ActiveSupport::Notifications::Event.new *args event.name # => "process_action.action_controller" event.duration # => 10 (in milliseconds) -- cgit v1.2.3 From 8dd2c71d2671ddc87bfdf18ebb35a4ca382e59f6 Mon Sep 17 00:00:00 2001 From: Vijay Dev Date: Sat, 29 Dec 2012 00:07:02 +0530 Subject: Revert "reminder to run bundle after setting up rails-dev-box" This reverts commit 41381c19d1f3920ee9540aff0d35209cb43fb057. Reason: This doesn't quite fit the flow where it's added. Let's add this someplace else if it's explicitly required. [ci skip] --- guides/source/contributing_to_ruby_on_rails.md | 7 ------- 1 file changed, 7 deletions(-) (limited to 'guides/source') diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index 59c200fe0c..ce2a5a4902 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -49,13 +49,6 @@ To move on from submitting bugs to helping resolve existing issues or contributi The easiest and recommended way to get a development environment ready to hack is to use the [Rails development box](https://github.com/rails/rails-dev-box). -After you have setup your Rails development box and cloned your Rails fork on the host computer, don't forget to run Bundler before you start testing. - - host $ vagrant ssh - Welcome to Ubuntu 12.04 LTS... - ... - vagrant@rails-dev-box:~$ cd /vagrant/rails && bundle install - ### The Hard Way In case you can't use the Rails development box, see section above, check [this other guide](development_dependencies_install.html). -- cgit v1.2.3