From 37219bbb5afb82935c60d37889a84cc58cec12ae Mon Sep 17 00:00:00 2001 From: Nathan Wenneker Date: Sat, 3 Sep 2016 13:24:36 -0600 Subject: Update docs for change in transaction callback exceptions 07d3d40 changed how exceptions are handled in after_commit and after_destroy callbacks. This commit updates the 5.0 release notes and the ActiveRecord callback guide to reflect the new behavior. [ci skip] --- guides/source/5_0_release_notes.md | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'guides/source/5_0_release_notes.md') diff --git a/guides/source/5_0_release_notes.md b/guides/source/5_0_release_notes.md index 9c5ffb1d94..6538629972 100644 --- a/guides/source/5_0_release_notes.md +++ b/guides/source/5_0_release_notes.md @@ -797,6 +797,14 @@ Please refer to the [Changelog][active-record] for detailed changes. than the current time. ([Pull Request](https://github.com/rails/rails/pull/18956)) +* Change transaction callbacks to not swallow errors. + Before this change any errors raised inside a transaction callback + were getting rescued and printed in the logs, unless you used + the (newly deprecated) `raise_in_transactional_callbacks = true` option. + + Now these errors are not rescued anymore and just bubble up, as the other callbacks. + ([commit](https://github.com/rails/rails/commit/07d3d402341e81ada0214f2cb2be1da69eadfe72)) + Active Model ------------ -- cgit v1.2.3