From e5b1ab7cc39ff57f9789ffda75fb33f72187775d Mon Sep 17 00:00:00 2001
From: Joshua Peek <josh@joshpeek.com>
Date: Wed, 6 Aug 2008 14:50:02 -0500
Subject: MemoryStore is the only "unsafe" store. Make it threadsafe by
 default.

---
 activesupport/lib/active_support/cache.rb          | 18 ------
 .../lib/active_support/cache/memory_store.rb       | 55 ++++++++++++++----
 activesupport/test/caching_test.rb                 | 67 ----------------------
 3 files changed, 43 insertions(+), 97 deletions(-)

(limited to 'activesupport')

diff --git a/activesupport/lib/active_support/cache.rb b/activesupport/lib/active_support/cache.rb
index 5a064f8bea..95eae3a77e 100644
--- a/activesupport/lib/active_support/cache.rb
+++ b/activesupport/lib/active_support/cache.rb
@@ -39,10 +39,6 @@ module ActiveSupport
     class Store
       cattr_accessor :logger
 
-      def threadsafe!
-        extend ThreadSafety
-      end
-
       def silence!
         @silence = true
         self
@@ -115,20 +111,6 @@ module ActiveSupport
           logger.debug("Cache #{operation}: #{key}#{options ? " (#{options.inspect})" : ""}") if logger && !@silence && !@logger_off
         end
     end
-
-    module ThreadSafety #:nodoc:
-      def self.extended(object) #:nodoc:
-        object.instance_variable_set(:@mutex, Mutex.new)
-      end
-
-      %w(read write delete delete_matched exist? increment decrement).each do |method|
-        module_eval <<-EOS, __FILE__, __LINE__
-          def #{method}(*args)
-            @mutex.synchronize { super }
-          end
-        EOS
-      end
-    end
   end
 end
 
diff --git a/activesupport/lib/active_support/cache/memory_store.rb b/activesupport/lib/active_support/cache/memory_store.rb
index 6f114273e4..9332d50f24 100644
--- a/activesupport/lib/active_support/cache/memory_store.rb
+++ b/activesupport/lib/active_support/cache/memory_store.rb
@@ -3,36 +3,67 @@ module ActiveSupport
     class MemoryStore < Store
       def initialize
         @data = {}
+        @mutex = Mutex.new
+      end
+
+      def fetch(key, options = {})
+        @mutex.synchronize do
+          super
+        end
       end
 
       def read(name, options = nil)
-        super
-        @data[name]
+        @mutex.synchronize do
+          super
+          @data[name]
+        end
       end
 
       def write(name, value, options = nil)
-        super
-        @data[name] = value
+        @mutex.synchronize do
+          super
+          @data[name] = value
+        end
       end
 
       def delete(name, options = nil)
-        super
-        @data.delete(name)
+        @mutex.synchronize do
+          super
+          @data.delete(name)
+        end
       end
 
       def delete_matched(matcher, options = nil)
-        super
-        @data.delete_if { |k,v| k =~ matcher }
+        @mutex.synchronize do
+          super
+          @data.delete_if { |k,v| k =~ matcher }
+        end
       end
 
       def exist?(name,options = nil)
-        super
-        @data.has_key?(name)
+        @mutex.synchronize do
+          super
+          @data.has_key?(name)
+        end
+      end
+
+      def increment(key, amount = 1)
+        @mutex.synchronize do
+          super
+        end
+      end
+
+      def decrement(key, amount = 1)
+        @mutex.synchronize do
+          super
+        end
       end
 
       def clear
-        @data.clear
+        @mutex.synchronize do
+          @data.clear
+        end
       end
     end
   end
-end
\ No newline at end of file
+end
diff --git a/activesupport/test/caching_test.rb b/activesupport/test/caching_test.rb
index 0af4251962..f3220d27aa 100644
--- a/activesupport/test/caching_test.rb
+++ b/activesupport/test/caching_test.rb
@@ -70,70 +70,3 @@ uses_mocha 'high-level cache store tests' do
     end
   end
 end
-
-class ThreadSafetyCacheStoreTest < Test::Unit::TestCase
-  def setup
-    @cache = ActiveSupport::Cache.lookup_store(:memory_store).threadsafe!
-    @cache.write('foo', 'bar')
-
-    # No way to have mocha proxy to the original method
-    @mutex = @cache.instance_variable_get(:@mutex)
-    @mutex.instance_eval %(
-      def calls; @calls; end
-      def synchronize
-        @calls ||= 0
-        @calls += 1
-        yield
-      end
-    )
-  end
-
-  def test_read_is_synchronized
-    assert_equal 'bar', @cache.read('foo')
-    assert_equal 1, @mutex.calls
-  end
-
-  def test_write_is_synchronized
-    @cache.write('foo', 'baz')
-    assert_equal 'baz', @cache.read('foo')
-    assert_equal 2, @mutex.calls
-  end
-
-  def test_delete_is_synchronized
-    assert_equal 'bar', @cache.read('foo')
-    @cache.delete('foo')
-    assert_equal nil, @cache.read('foo')
-    assert_equal 3, @mutex.calls
-  end
-
-  def test_delete_matched_is_synchronized
-    assert_equal 'bar', @cache.read('foo')
-    @cache.delete_matched(/foo/)
-    assert_equal nil, @cache.read('foo')
-    assert_equal 3, @mutex.calls
-  end
-
-  def test_fetch_is_synchronized
-    assert_equal 'bar', @cache.fetch('foo') { 'baz' }
-    assert_equal 'fu', @cache.fetch('bar') { 'fu' }
-    assert_equal 3, @mutex.calls
-  end
-
-  def test_exist_is_synchronized
-    assert @cache.exist?('foo')
-    assert !@cache.exist?('bar')
-    assert_equal 2, @mutex.calls
-  end
-
-  def test_increment_is_synchronized
-    @cache.write('foo_count', 1)
-    assert_equal 2, @cache.increment('foo_count')
-    assert_equal 4, @mutex.calls
-  end
-
-  def test_decrement_is_synchronized
-    @cache.write('foo_count', 1)
-    assert_equal 0, @cache.decrement('foo_count')
-    assert_equal 4, @mutex.calls
-  end
-end
-- 
cgit v1.2.3