From be0d235a3b82e72de49592913753a1f291a98f86 Mon Sep 17 00:00:00 2001
From: Joshua Peek <josh@joshpeek.com>
Date: Wed, 6 Aug 2008 20:21:15 -0500
Subject: Optimize memoized method if there are no arguments

---
 activesupport/lib/active_support/memoizable.rb | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

(limited to 'activesupport')

diff --git a/activesupport/lib/active_support/memoizable.rb b/activesupport/lib/active_support/memoizable.rb
index 23dd96e4df..7e2e28712c 100644
--- a/activesupport/lib/active_support/memoizable.rb
+++ b/activesupport/lib/active_support/memoizable.rb
@@ -29,14 +29,24 @@ module ActiveSupport
           raise "Already memoized #{symbol}" if method_defined?(:#{original_method})
           alias #{original_method} #{symbol}
 
-          def #{symbol}(*args)
-            #{memoized_ivar} ||= {}
-            reload = args.pop if args.last == true || args.last == :reload
+          if instance_method(:#{symbol}).arity == 0
+            def #{symbol}(reload = false)
+              if !reload && defined? #{memoized_ivar}
+                #{memoized_ivar}
+              else
+                #{memoized_ivar} = #{original_method}.freeze
+              end
+            end
+          else
+            def #{symbol}(*args)
+              #{memoized_ivar} ||= {}
+              reload = args.pop if args.last == true || args.last == :reload
 
-            if !reload && #{memoized_ivar} && #{memoized_ivar}.has_key?(args)
-              #{memoized_ivar}[args]
-            else
-              #{memoized_ivar}[args] = #{original_method}(*args).freeze
+              if !reload && #{memoized_ivar} && #{memoized_ivar}.has_key?(args)
+                #{memoized_ivar}[args]
+              else
+                #{memoized_ivar}[args] = #{original_method}(*args).freeze
+              end
             end
           end
         EOS
-- 
cgit v1.2.3