From d2890f76d49542ab853bfcbe5f1c4c6924231591 Mon Sep 17 00:00:00 2001 From: Andrew White Date: Sun, 13 Nov 2016 15:31:05 +0000 Subject: Use literal values in assertions Using the method you're testing to generate expected values can lead to bugs being masked. --- activesupport/test/json/encoding_test.rb | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'activesupport/test') diff --git a/activesupport/test/json/encoding_test.rb b/activesupport/test/json/encoding_test.rb index e745f5e190..95bdc4283a 100644 --- a/activesupport/test/json/encoding_test.rb +++ b/activesupport/test/json/encoding_test.rb @@ -434,24 +434,22 @@ EXPECTED class InfiniteNumber def as_json(options = nil) - { "number" => 1.0 / 0 } + { "number" => Float::INFINITY } end end def test_to_json_works_when_as_json_returns_infinite_number - expected = { number: nil }.to_json - assert_equal expected, InfiniteNumber.new.to_json + assert_equal '{"number":null}', InfiniteNumber.new.to_json end class NaNNumber def as_json(options = nil) - { "number" => 0.0 / 0 } + { "number" => Float::INFINITY } end end def test_to_json_works_when_as_json_returns_NaN_number - expected = { number: nil }.to_json - assert_equal expected, NaNNumber.new.to_json + assert_equal '{"number":null}', NaNNumber.new.to_json end protected -- cgit v1.2.3