From 8a130ece7e265f1e94abef8d64d5c6880797e831 Mon Sep 17 00:00:00 2001 From: Jeremy Kemper Date: Fri, 28 Dec 2012 21:47:42 -0700 Subject: Test that assert_not returns true. Use assert_raises instead of doing begin/rescue/else. --- activesupport/test/test_test.rb | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) (limited to 'activesupport/test') diff --git a/activesupport/test/test_test.rb b/activesupport/test/test_test.rb index 44fe648710..0f93c8b59e 100644 --- a/activesupport/test/test_test.rb +++ b/activesupport/test/test_test.rb @@ -16,24 +16,14 @@ class AssertDifferenceTest < ActiveSupport::TestCase end def test_assert_not - assert_not nil - assert_not false - - begin - assert_not true - rescue Exception => e - assert_equal 'Expected true to be nil or false', e.message - else - fail 'assert_not true should fail' - end + assert_equal true, assert_not(nil) + assert_equal true, assert_not(false) - begin - assert_not true, 'custom' - rescue Exception => e - assert_equal 'custom', e.message - else - fail 'assert_not true should fail' - end + e = assert_raises(MiniTest::Assertion) { assert_not true } + assert_equal 'Expected true to be nil or false', e.message + + e = assert_raises(MiniTest::Assertion) { assert_not true, 'custom' } + assert_equal 'custom', e.message end def test_assert_no_difference -- cgit v1.2.3