From 43fdbd5e1ff48f1b55963a6bf3fbbdd3f90f0d67 Mon Sep 17 00:00:00 2001 From: Jeremy Kemper Date: Thu, 20 Dec 2007 22:28:47 +0000 Subject: Hash#symbolize_keys skips keys that can't be symbolized. Closes #10500. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activesupport/test/core_ext/hash_ext_test.rb | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'activesupport/test/core_ext/hash_ext_test.rb') diff --git a/activesupport/test/core_ext/hash_ext_test.rb b/activesupport/test/core_ext/hash_ext_test.rb index 4d01faa5d2..a39c32a2e3 100644 --- a/activesupport/test/core_ext/hash_ext_test.rb +++ b/activesupport/test/core_ext/hash_ext_test.rb @@ -6,6 +6,11 @@ class HashExtTest < Test::Unit::TestCase @symbols = { :a => 1, :b => 2 } @mixed = { :a => 1, 'b' => 2 } @fixnums = { 0 => 1, 1 => 2 } + if RUBY_VERSION < '1.9.0' + @illegal_symbols = { "\0" => 1, "" => 2, [] => 3 } + else + @illegal_symbols = { [] => 3 } + end end def test_methods @@ -22,16 +27,17 @@ class HashExtTest < Test::Unit::TestCase assert_equal @symbols, @symbols.symbolize_keys assert_equal @symbols, @strings.symbolize_keys assert_equal @symbols, @mixed.symbolize_keys - - assert_raises(NoMethodError) { { [] => 1 }.symbolize_keys } end def test_symbolize_keys! assert_equal @symbols, @symbols.dup.symbolize_keys! assert_equal @symbols, @strings.dup.symbolize_keys! assert_equal @symbols, @mixed.dup.symbolize_keys! + end - assert_raises(NoMethodError) { { [] => 1 }.symbolize_keys } + def test_symbolize_keys_preserves_keys_that_cant_be_symbolized + assert_equal @illegal_symbols, @illegal_symbols.symbolize_keys + assert_equal @illegal_symbols, @illegal_symbols.dup.symbolize_keys! end def test_symbolize_keys_preserves_fixnum_keys -- cgit v1.2.3