From af02b9b78f7b735345a891222532d32caf871520 Mon Sep 17 00:00:00 2001 From: George Claghorn Date: Tue, 17 Jul 2018 16:23:53 -0400 Subject: Remove unnecessary tap --- activestorage/test/models/attached/many_test.rb | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'activestorage/test') diff --git a/activestorage/test/models/attached/many_test.rb b/activestorage/test/models/attached/many_test.rb index 24974a78a6..82be88af08 100644 --- a/activestorage/test/models/attached/many_test.rb +++ b/activestorage/test/models/attached/many_test.rb @@ -170,19 +170,17 @@ class ActiveStorage::ManyAttachedTest < ActiveSupport::TestCase end test "replacing existing, independent attachments on an existing record via assign and attach" do - [ create_blob(filename: "funky.mp4"), create_blob(filename: "town.mp4") ].tap do |old_blobs| - @user.vlogs.attach old_blobs - - @user.vlogs = [] - assert_not @user.vlogs.attached? + @user.vlogs.attach create_blob(filename: "funky.mp4"), create_blob(filename: "town.mp4") - assert_no_enqueued_jobs only: ActiveStorage::PurgeJob do - @user.vlogs.attach create_blob(filename: "whenever.mp4"), create_blob(filename: "wherever.mp4") - end + @user.vlogs = [] + assert_not @user.vlogs.attached? - assert_equal "whenever.mp4", @user.vlogs.first.filename.to_s - assert_equal "wherever.mp4", @user.vlogs.second.filename.to_s + assert_no_enqueued_jobs only: ActiveStorage::PurgeJob do + @user.vlogs.attach create_blob(filename: "whenever.mp4"), create_blob(filename: "wherever.mp4") end + + assert_equal "whenever.mp4", @user.vlogs.first.filename.to_s + assert_equal "wherever.mp4", @user.vlogs.second.filename.to_s end test "successfully updating an existing record to replace existing, dependent attachments" do -- cgit v1.2.3