From 052fcef0cb405a3fa3a46349a9d979c2e0d4c160 Mon Sep 17 00:00:00 2001 From: George Claghorn Date: Wed, 25 Apr 2018 12:47:54 -0500 Subject: Simplify URL generation for partial downloads from GCS --- activestorage/lib/active_storage/service/gcs_service.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'activestorage/lib') diff --git a/activestorage/lib/active_storage/service/gcs_service.rb b/activestorage/lib/active_storage/service/gcs_service.rb index 369c33cbdb..16a0765fc5 100644 --- a/activestorage/lib/active_storage/service/gcs_service.rb +++ b/activestorage/lib/active_storage/service/gcs_service.rb @@ -48,7 +48,8 @@ module ActiveStorage def download_chunk(key, range) instrument :download_chunk, key: key, range: range do - uri = URI(url(key, expires_in: 30.seconds, filename: ActiveStorage::Filename.new(""), content_type: "application/octet-stream", disposition: "inline")) + file = file_for(key) + uri = URI(file.signed_url(expires: 30.seconds)) Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == "https") do |client| client.get(uri, "Range" => "bytes=#{range.begin}-#{range.exclude_end? ? range.end - 1 : range.end}").body -- cgit v1.2.3