From cf1c48478d1f48d763c3bee92d6bc6cfb3e63dba Mon Sep 17 00:00:00 2001 From: George Claghorn Date: Sat, 20 Jan 2018 14:47:04 -0500 Subject: Cope with videos with undefined display aspect ratios --- activestorage/lib/active_storage/analyzer/video_analyzer.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'activestorage/lib/active_storage/analyzer/video_analyzer.rb') diff --git a/activestorage/lib/active_storage/analyzer/video_analyzer.rb b/activestorage/lib/active_storage/analyzer/video_analyzer.rb index f0d9baa199..656e362187 100644 --- a/activestorage/lib/active_storage/analyzer/video_analyzer.rb +++ b/activestorage/lib/active_storage/analyzer/video_analyzer.rb @@ -55,8 +55,12 @@ module ActiveStorage def display_aspect_ratio if descriptor = video_stream["display_aspect_ratio"] - terms = descriptor.split(":", 2).collect(&:to_i) - terms if terms.count == 2 && terms.min >= 0 + if terms = descriptor.split(":", 2) + numerator = Integer(terms[0]) + denominator = Integer(terms[1]) + + [numerator, denominator] unless numerator == 0 + end end end -- cgit v1.2.3