From d8e5751a1d7ad027519463134fe1a861d02494fc Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Sat, 31 Dec 2016 19:22:49 +0900 Subject: Extract `casted_true`/`casted_false` for `Type::ImmutableString` The only difference between `Type::ImmutableString` and its subclasses is the representation of the casted booleans. Prefer extracting `casted_true`/`casted_false` and override these by subclasses. --- .../connection_adapters/abstract_mysql_adapter.rb | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) (limited to 'activerecord') diff --git a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb index 1c3d10c15d..97bc5edd4b 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb @@ -979,22 +979,14 @@ module ActiveRecord end class MysqlString < Type::String # :nodoc: - def serialize(value) - case value - when true then MySQL::Quoting::QUOTED_TRUE - when false then MySQL::Quoting::QUOTED_FALSE - else super - end - end - private - def cast_value(value) - case value - when true then MySQL::Quoting::QUOTED_TRUE - when false then MySQL::Quoting::QUOTED_FALSE - else super - end + def casted_true + MySQL::Quoting::QUOTED_TRUE + end + + def casted_false + MySQL::Quoting::QUOTED_FALSE end end -- cgit v1.2.3