From b217e6e7d318da6d9bfa52a6f68ca2b96bb9bd82 Mon Sep 17 00:00:00 2001 From: Willian Gustavo Veiga Date: Wed, 24 Oct 2018 20:29:13 -0300 Subject: Avoid creating an extra relation instance --- activerecord/lib/active_record/relation/query_methods.rb | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'activerecord') diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index 94c42fb630..b41cbf6f48 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -250,8 +250,15 @@ module ActiveRecord # # This is short-hand for unscope(:select).select(fields). # Note that we're unscoping the entire select statement. - def reselect(*fields) - unscope(:select).select(*fields) + def reselect(*args) + check_if_method_has_arguments!(:reselect, args) + spawn.reselect!(*args) + end + + # Same as #reselect but operates on relation in-place instead of copying. + def reselect!(*args) # :nodoc: + self.select_values = args + self end # Allows to specify a group attribute: -- cgit v1.2.3