From a5991d849175c2ae9b803486f61b610fad9fd87e Mon Sep 17 00:00:00 2001 From: Rick Olson Date: Sun, 26 Mar 2006 04:13:25 +0000 Subject: Change periods (.) in table aliases to _'s. Closes #4251 [jeff@ministrycentered.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activerecord/CHANGELOG | 2 ++ .../lib/active_record/connection_adapters/abstract/schema_statements.rb | 2 +- activerecord/test/adapter_test.rb | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) (limited to 'activerecord') diff --git a/activerecord/CHANGELOG b/activerecord/CHANGELOG index f21d6e7f97..a1a0e63c86 100644 --- a/activerecord/CHANGELOG +++ b/activerecord/CHANGELOG @@ -1,5 +1,7 @@ *SVN* +* Change periods (.) in table aliases to _'s. Closes #4251 [jeff@ministrycentered.com] + * Changed has_and_belongs_to_many join to INNER JOIN for Mysql 3.23.x. Closes #4348 [Rick] * Fixed issue that kept :select options from being scoped [Rick] diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb index 8c94f07db9..c005282223 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb @@ -15,7 +15,7 @@ module ActiveRecord # Truncates a table alias according to the limits of the current adapter. def table_alias_for(table_name) - table_name[0..table_alias_length-1] + table_name[0..table_alias_length-1].gsub(/\./, '_') end # def tables(name = nil) end diff --git a/activerecord/test/adapter_test.rb b/activerecord/test/adapter_test.rb index 93e1ca973b..3da1bf3e54 100644 --- a/activerecord/test/adapter_test.rb +++ b/activerecord/test/adapter_test.rb @@ -57,6 +57,7 @@ class AdapterTest < Test::Unit::TestCase assert_equal 'posts', @connection.table_alias_for('posts') assert_equal 'posts_comm', @connection.table_alias_for('posts_comments') + assert_equal 'dbo_posts', @connection.table_alias_for('dbo.posts') class << @connection alias_method :table_alias_length, :old_table_alias_length -- cgit v1.2.3