From 9cbb6d2b20a8e3352bedd791fafe3c58f8bef328 Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Fri, 24 Aug 2012 17:06:02 -0700 Subject: use Hash#fetch to eliminate conditional --- .../connection_adapters/abstract/database_statements.rb | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'activerecord') diff --git a/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb index 02459763f7..4e1f0e1d62 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb @@ -174,14 +174,9 @@ module ActiveRecord options.assert_valid_keys :requires_new, :joinable last_transaction_joinable = @transaction_joinable - if options.has_key?(:joinable) - @transaction_joinable = options[:joinable] - else - @transaction_joinable = true - end - requires_new = options[:requires_new] || !last_transaction_joinable - - transaction_open = false + @transaction_joinable = options.fetch(:joinable, true) + requires_new = options[:requires_new] || !last_transaction_joinable + transaction_open = false begin if requires_new || open_transactions == 0 -- cgit v1.2.3